Improve Java to Ballerina call logic #2135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
warunalakshitha
requested review from
shafreenAnfar,
ThisaruGuruge,
DimuthuMadushan and
MohamedSabthar
as code owners
|
warunalakshitha
commented
Dec 19, 2024
| @@ -67,15 +63,11 @@ private static Object invokeClientMethod(Environment env, BObject client, BStrin | |||
|
|
|||
| private static Object invokeClientMethod(Environment env, BObject client, String methodName, Object[] paramFeed) { | |||
| return env.yieldAndRun(() -> { | |||
| CompletableFuture<Object> balFuture = new CompletableFuture<>(); | |||
There was a problem hiding this comment.
No need to creating future now. we can directly pass the result
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Found some native code can be improved when testing hanging issue.
Fixes:
Examples
Checklist
commonspackage changes (if there are any, please update the GraphQL version in GraphQL tools and Ballerina dev tools)compilerpackage changes (if there are any, please update the GraphQL version in Ballerina dev tools)