Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update input param validation logic #207

Merged
merged 4 commits into from
May 11, 2021

Conversation

aashikam
Copy link
Contributor

@aashikam aashikam commented May 11, 2021

Fixes: ballerina-platform/ballerina-library#1339

Purpose

$title

Checklist

  • Linked to an issue
  • Updated the changelog
  • Added tests

@aashikam aashikam requested a review from ThisaruGuruge May 11, 2021 04:50
Copy link
Member

@ThisaruGuruge ThisaruGuruge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Shall we update the changelog as well?

@codecov
Copy link

codecov bot commented May 11, 2021

Codecov Report

Merging #207 (7940d20) into master (c76d35d) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #207   +/-   ##
=========================================
  Coverage     89.81%   89.81%           
  Complexity      196      196           
=========================================
  Files            41       41           
  Lines          1689     1689           
  Branches        689      689           
=========================================
  Hits           1517     1517           
  Misses          156      156           
  Partials         16       16           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c76d35d...7940d20. Read the comment docs.

changelog.md Outdated Show resolved Hide resolved
changelog.md Show resolved Hide resolved
aashikam and others added 2 commits May 11, 2021 11:25
@ThisaruGuruge ThisaruGuruge merged commit ca5b5db into ballerina-platform:master May 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[GraphQL Compiler Plugin] Input types should be valid for the union of (any valid type or nil)
2 participants