Make some Java classes proper utilities #1615
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Made the design cleaner by marking Java classes as `final` and explicitly declaring their default constructors as `private`. This change makes the code coverage reports more accurate. Fixes #4911.
vil02
requested review from
shafreenAnfar,
ThisaruGuruge and
DimuthuMadushan
as code owners
|
Kudos, SonarCloud Quality Gate passed!
|
ThisaruGuruge
approved these changes
Oct 13, 2023
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1615 +/- ##
============================================
+ Coverage 85.32% 86.57% +1.24%
- Complexity 0 678 +678
============================================
Files 98 123 +25
Lines 6446 8810 +2364
Branches 3098 3515 +417
============================================
+ Hits 5500 7627 +2127
- Misses 872 903 +31
- Partials 74 280 +206
☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Fixes: ballerina-platform/ballerina-library#4911.
Examples
Checklist
commonspackage changes (if there are any, please update the GraphQL version in GraphQL tools and Ballerina dev tools)compilerpackage changes (if there are any, please update the GraphQL version in Ballerina dev tools)Remarks for reviewers
I am not sure what exactly should be done regarding: