Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add DataLoader functionality #1566

Merged
merged 57 commits into from
Aug 4, 2023
Merged

Add DataLoader functionality #1566

merged 57 commits into from
Aug 4, 2023

Conversation

MohamedSabthar
Copy link
Member

@MohamedSabthar MohamedSabthar commented Aug 2, 2023 •
edited
Loading

Purpose

Fixes: ballerina-platform/ballerina-library#4569

  • Minor refactoring changes

Examples

Checklist

  • Linked to an issue
  • Updated the changelog
  • Added tests
  • Updated the spec
  • Checked native-image compatibility
  • No commons package changes (if there are any, please update the GraphQL version in GraphQL tools)

@MohamedSabthar
[Automated] Update the native jar versions
f63df92
@MohamedSabthar
[Automated] Update the native jar versions
8405d39
@MohamedSabthar
Merge branch 'master' of https://github.com/ballerina-platform/module…
9f45bee 
…-ballerina-graphql into loader-impl
@MohamedSabthar
Merge branch 'master' of https://github.com/ballerina-platform/module…
1306e51 
…-ballerina-graphql into ld-ref
@MohamedSabthar
[Automated] Update the native jar versions
ff4e693
@MohamedSabthar
[Automated] Update the native jar versions
65b0927
@MohamedSabthar
Add DataLoader functionality
0560074
@MohamedSabthar
Avoid rebuilding branches that does not contain place holder nodes
1c6e88a
@MohamedSabthar
Add new line to engine_utils.bal
d0a1da6
@MohamedSabthar
Refactor engine resolve method
2c925c1
@MohamedSabthar
[Automated] Update the native jar versions
11f0cb2
@MohamedSabthar
Update spec with dataloader experimental feature
a1bade9
@MohamedSabthar
Add dataloader proposal
7737e9a
@MohamedSabthar
Fix typo in spec
acc9023
@MohamedSabthar
Update spec TOC
8b5b8b2
@MohamedSabthar
Address review suggestions
f6c6e97
@MohamedSabthar
Merge branch 'master' of https://github.com/ballerina-platform/module…
02fed57 
…-ballerina-graphql into dataloader-impl
@MohamedSabthar
[Automated] Update the native jar versions
42e136b
@MohamedSabthar
[Automated] Update the native jar versions
a0b26bd
@MohamedSabthar
Merge branch 'master' into dataloader-impl
c3b5358
@MohamedSabthar
Refactor ballerina code having dataloader
1d0c6ba
@MohamedSabthar
Merge branch 'dataloader-impl' of https://github.com/MohamedSabthar/m…
78af346 
…odule-ballerina-graphql into dataloader-impl
@MohamedSabthar
[Automated] Update the native jar versions
2d6255f
@MohamedSabthar
[Automated] Update the native jar versions
3ea19ac
@MohamedSabthar
Remove Dependencies.toml from compiler plugin test resource
16f4a24
@MohamedSabthar
[Automated] Update the native jar versions
46f8a82
@MohamedSabthar
[Automated] Update the native jar versions
6a104c9
@MohamedSabthar
Refactor java code
70f2953
@MohamedSabthar
Improve lowerCaseFirstChar method
91a7b2e
@MohamedSabthar
Refactor ballerina code
f179de0
@MohamedSabthar
Add Utilizing Multiple DataLoaders Example to Spec
19c8332
@MohamedSabthar
Merge branch 'master' of https://github.com/ballerina-platform/module…
845e4ef 
…-ballerina-graphql into dataloader-impl
@MohamedSabthar
Merge branch 'master' of https://github.com/ballerina-platform/module…
b058627 
…-ballerina-graphql into dataloader-impl
@MohamedSabthar
[Automated] Update the native jar versions
e21a0b0
@MohamedSabthar
[Automated] Update the native jar versions
f794a75
@MohamedSabthar
Merge branch 'master' into dataloader-impl
81b7b12
@MohamedSabthar
Update DataLoader API
0da460e
@MohamedSabthar
Update spec with DataLoader API changes
ae39fc3
@MohamedSabthar
Merge branch 'dataloader-impl' of https://github.com/MohamedSabthar/m…
c4ec75a 
…odule-ballerina-graphql into dataloader-impl
@MohamedSabthar
[Automated] Update the native jar versions
5eca820
@MohamedSabthar
[Automated] Update the native jar versions
43066b6
@MohamedSabthar
Update prefetch method validation code
f8bf357
@codecov
Copy link

codecov bot commented Aug 2, 2023 •
edited
Loading

Codecov Report

Patch coverage: 88.15% and project coverage change: +1.37% 🎉

Comparison is base (2c55e65) 85.42% compared to head (d1a8826) 86.79%.
Report is 86 commits behind head on master.

Additional details and impacted files 
@@             Coverage Diff              @@
##             master    #1566      +/-   ##
============================================
+ Coverage     85.42%   86.79%   +1.37%     
- Complexity        0      631     +631     
============================================
  Files            94      121      +27     
  Lines          6279     8628    +2349     
  Branches       3027     3476     +449     
============================================
+ Hits           5364     7489    +2125     
- Misses          848      877      +29     
- Partials         67      262     +195
Files Changed Coverage Δ
ballerina/annotations.bal 100.00% <ø> (ø)
ballerina/common_utils.bal 91.79% <ø> (ø)
ballerina/modules/parser/utils.bal 83.01% <ø> (ø)
.../ballerina/stdlib/graphql/commons/utils/Utils.java 75.60% <ø> (+75.60%) ⬆️
...dlib/graphql/runtime/engine/ExecutionCallback.java 62.50% <ø> (ø)
...va/io/ballerina/stdlib/graphql/compiler/Utils.java 63.70% <66.66%> (ø)
...rvice/validator/FunctionDefinitionNodeVisitor.java 71.42% <71.42%> (ø)
...rina/stdlib/graphql/runtime/engine/DataLoader.java 75.00% <75.00%> (ø)
ballerina/value_tree_builder.bal 80.95% <80.95%> (ø)
...vice/validator/ResourceConfigAnnotationFinder.java 82.35% <82.35%> (ø)
... and 18 more

... and 32 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MohamedSabthar MohamedSabthar marked this pull request as draft August 2, 2023 06:05
@MohamedSabthar MohamedSabthar marked this pull request as ready for review August 2, 2023 07:59
ThisaruGuruge
ThisaruGuruge reviewed Aug 3, 2023
View reviewed changes
ballerina-tests/tests/test_services.bal Outdated Show resolved Hide resolved
ballerina/context.bal Outdated Show resolved Hide resolved
ballerina/engine_utils.bal Outdated Show resolved Hide resolved
...-plugin-tests/src/test/resources/ballerina_sources/generator_tests/24_dataloader/service.bal Outdated Show resolved Hide resolved
compiler-plugin/src/main/java/io/ballerina/stdlib/graphql/compiler/Utils.java Outdated Show resolved Hide resolved
docs/spec/spec.md Outdated Show resolved Hide resolved
docs/spec/spec.md Outdated Show resolved Hide resolved
docs/spec/spec.md Outdated Show resolved Hide resolved
native/src/main/java/io/ballerina/stdlib/graphql/runtime/engine/ArgumentHandler.java Outdated Show resolved Hide resolved
native/src/main/java/io/ballerina/stdlib/graphql/runtime/engine/Engine.java Outdated Show resolved Hide resolved
@sonarqubecloud
Copy link

sonarqubecloud bot commented Aug 3, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@ThisaruGuruge ThisaruGuruge merged commit 05e981e into ballerina-platform:master Aug 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ThisaruGuruge ThisaruGuruge ThisaruGuruge approved these changes

@shafreenAnfar shafreenAnfar Awaiting requested review from shafreenAnfar shafreenAnfar is a code owner

@DimuthuMadushan DimuthuMadushan Awaiting requested review from DimuthuMadushan DimuthuMadushan is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Proposal: Introduce DataLoader for Ballerina GraphQL
2 participants
@MohamedSabthar @ThisaruGuruge