Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix resolver returning null when record has service objects or map of service objects as its field #1029

Merged
merged 8 commits into from
Nov 4, 2022

Conversation

MohamedSabthar
Copy link
Member

@MohamedSabthar MohamedSabthar commented Nov 2, 2022

Purpose

Fixes: #3466
Fixes: #3579

Examples

Checklist

  • Linked to an issue
  • Updated the changelog
  • Added tests
  • Updated the spec
  • Checked native-image compatibility

@codecov
Copy link

codecov bot commented Nov 2, 2022

Codecov Report

Base: 86.75% // Head: 86.78% // Increases project coverage by +0.02% 🎉

Coverage data is based on head (fbb3ab4) compared to base (2bf672b).
Patch coverage: 100.00% of modified lines in pull request are covered.

❗ Current head fbb3ab4 differs from pull request most recent head ed496e9. Consider uploading reports for the commit ed496e9 to get more accurate results

Additional details and impacted files
@@             Coverage Diff              @@
##           2201.2.x    #1029      +/-   ##
============================================
+ Coverage     86.75%   86.78%   +0.02%     
============================================
  Files            60       60              
  Lines          4531     4533       +2     
  Branches       2497     2496       -1     
============================================
+ Hits           3931     3934       +3     
  Misses          557      557              
+ Partials         43       42       -1     
Impacted Files Coverage Δ
ballerina/engine_utils.bal 96.42% <100.00%> (ø)
ballerina/response_generator.bal 95.23% <100.00%> (+0.07%) ⬆️
...allerina/stdlib/graphql/runtime/engine/Engine.java 79.36% <0.00%> (+0.79%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@MohamedSabthar MohamedSabthar marked this pull request as ready for review November 2, 2022 04:49
Copy link
Member

@ThisaruGuruge ThisaruGuruge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How does this handle the subscription scenarios? SInce the subscriptions are handled through a separate flor in 2201.2.x branch, we have to fix that.

@MohamedSabthar
Copy link
Member Author

How does this handle the subscription scenarios? SInce the subscriptions are handled through a separate flor in 2201.2.x branch, we have to fix that.

Yes I noticed subscription is handled in java level and this bug is not present in java implementation. I'll update the PR with test cases for subscription

@MohamedSabthar MohamedSabthar merged commit ac4f0de into ballerina-platform:2201.2.x Nov 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants