Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow reflection access to sun.security.util.HostnameChecker #165

Merged
merged 2 commits into from
May 7, 2021
Merged

Conversation

Maninda
Copy link
Member

@Maninda Maninda commented May 6, 2021

Purpose

Resolves ballerina-platform/ballerina-library#1136

Checklist

  • Linked to an issue
  • Updated the changelog
  • Added tests

@Maninda Maninda self-assigned this May 6, 2021
@codecov
Copy link

codecov bot commented May 6, 2021

Codecov Report

Merging #165 (15472ff) into master (990d81d) will decrease coverage by 0.19%.
The diff coverage is 70.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #165      +/-   ##
============================================
- Coverage     80.23%   80.03%   -0.20%     
  Complexity      148      148              
============================================
  Files            22       22              
  Lines          1012     1032      +20     
  Branches        217      219       +2     
============================================
+ Hits            812      826      +14     
- Misses          114      118       +4     
- Partials         86       88       +2     
Impacted Files Coverage Δ Complexity Δ
...allerinalang/stdlib/email/util/EmailConstants.java 100.00% <ø> (ø) 1.00 <0.00> (ø)
...inalang/stdlib/email/client/EmailAccessClient.java 68.14% <70.00%> (+0.18%) 12.00 <0.00> (ø)
.../ballerinalang/stdlib/email/client/SmtpClient.java 74.19% <70.00%> (-2.00%) 3.00 <0.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 990d81d...15472ff. Read the comment docs.

@Maninda Maninda merged commit 84dc286 into master May 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Gets warning logs when connecting to gmail
2 participants