-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix issues regarding finites type with byte values #63
Merged
gimantha
merged 9 commits into
ballerina-platform:main
from
SasinduDilshara:test_semtype_failure
Dec 4, 2024
Merged
Fix issues regarding finites type with byte values #63
gimantha
merged 9 commits into
ballerina-platform:main
from
SasinduDilshara:test_semtype_failure
Dec 4, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gimantha
previously approved these changes
Dec 4, 2024
chiranSachintha
previously approved these changes
Dec 4, 2024
chiranSachintha
approved these changes
Dec 4, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #63 +/- ##
============================================
- Coverage 86.01% 85.31% -0.70%
- Complexity 792 906 +114
============================================
Files 25 31 +6
Lines 3381 3752 +371
Branches 672 756 +84
============================================
+ Hits 2908 3201 +293
- Misses 295 332 +37
- Partials 178 219 +41 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is due to the failures in https://github.com/ballerina-platform/ballerina-lang/actions/runs/12150965444/job/33884989518?pr=43606.
With the new semtype changes, few behaviours are changed in finite types.
Consider a Singleton type like following
Before semtype, this value
1
(inside the finite type) is treated as a Long, after semtype it is treated as aInteger
in runtime.So the output of the
TypeUtils.getType
is different in the twocases.Thats the reason for the test failures