Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issues regarding finites type with byte values #63

Merged

Conversation

SasinduDilshara
Copy link
Contributor

This PR is due to the failures in https://github.com/ballerina-platform/ballerina-lang/actions/runs/12150965444/job/33884989518?pr=43606.

With the new semtype changes, few behaviours are changed in finite types.

Consider a Singleton type like following

type FiniteType true|"A"|1|2;

Before semtype, this value 1(inside the finite type) is treated as a Long, after semtype it is treated as a Integer in runtime.
So the output of the TypeUtils.getType is different in the twocases.
Thats the reason for the test failures

gimantha
gimantha previously approved these changes Dec 4, 2024
chiranSachintha
chiranSachintha previously approved these changes Dec 4, 2024
Copy link

codecov bot commented Dec 4, 2024

Codecov Report

Attention: Patch coverage is 72.72727% with 3 lines in your changes missing coverage. Please review.

Project coverage is 85.31%. Comparing base (14aff6e) to head (478a9e2).
Report is 14 commits behind head on main.

Files with missing lines Patch % Lines
...java/io/ballerina/lib/data/xmldata/FromString.java 72.72% 1 Missing and 2 partials ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main      #63      +/-   ##
============================================
- Coverage     86.01%   85.31%   -0.70%     
- Complexity      792      906     +114     
============================================
  Files            25       31       +6     
  Lines          3381     3752     +371     
  Branches        672      756      +84     
============================================
+ Hits           2908     3201     +293     
- Misses          295      332      +37     
- Partials        178      219      +41     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gimantha gimantha merged commit a9c815d into ballerina-platform:main Dec 4, 2024
4 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants