Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix found bugs in XML data library #5

Merged
merged 8 commits into from
Mar 20, 2024

Conversation

prakanth97
Copy link
Contributor

Purpose

Fixes: #6092

Examples

Checklist

  • Linked to an issue
  • Updated the changelog
  • Added tests
  • Updated the spec
  • Checked native-image compatibility

@prakanth97 prakanth97 requested a review from hasithaa as a code owner February 26, 2024 02:31
Copy link

codecov bot commented Feb 26, 2024

Codecov Report

Attention: Patch coverage is 88.76812% with 31 lines in your changes are missing coverage. Please review.

Project coverage is 78.25%. Comparing base (931e925) to head (0d7066b).
Report is 5 commits behind head on main.

Files Patch % Lines
.../xmldata/compiler/XmldataRecordFieldValidator.java 79.66% 4 Missing and 8 partials ⚠️
...o/ballerina/stdlib/data/xmldata/xml/XmlParser.java 92.98% 0 Missing and 8 partials ⚠️
...ballerina/stdlib/data/xmldata/utils/DataUtils.java 60.00% 3 Missing and 3 partials ⚠️
...allerina/stdlib/data/xmldata/xml/XmlTraversal.java 93.87% 2 Missing and 1 partial ⚠️
ballerina/xml_api.bal 0.00% 1 Missing ⚠️
...llerina/stdlib/data/xmldata/xml/QualifiedName.java 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main       #5      +/-   ##
============================================
+ Coverage     74.35%   78.25%   +3.89%     
- Complexity      384      449      +65     
============================================
  Files            21       21              
  Lines          1833     2005     +172     
  Branches        420      440      +20     
============================================
+ Hits           1363     1569     +206     
+ Misses          370      328      -42     
- Partials        100      108       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

README.md Outdated Show resolved Hide resolved
@SasinduDilshara
Copy link
Contributor

LGTM

@prakanth97 prakanth97 merged commit 7ed4f4b into ballerina-platform:main Mar 20, 2024
7 checks passed
prakanth97 added a commit to prakanth97/module-ballerina-data-xmldata that referenced this pull request Aug 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants