Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix JSON to EDI Data Binding in REST client #55

Merged
merged 5 commits into from
Aug 2, 2024

Conversation

RDPerera
Copy link
Member

@RDPerera RDPerera commented Aug 2, 2024

Fixes: ballerina-platform/ballerina-library#6813

This pull request introduces several enhancements and fixes to the EDI REST codegen functionality. Below are the key changes included in this PR:

  1. Limit Package Name Length: The organization and package name length has been limited to a maximum of 256 characters. This change helps ensure that our package naming conventions adhere to commonly accepted standards and prevents issues related to overly long names that could affect system performance and usability.

  2. Fix JSON to EDI Code Generation: Addressed an issue in the JSON to EDI REST code generation process. This fix ensures that the conversion logic correctly handles all specified edge cases, improving the reliability of our code generation tool.

  3. Add Examples for REST Codegen: Added new examples to the REST code generation documentation. These examples are intended to provide clearer guidance and support for users utilizing our codegen tools, demonstrating practical use cases and enhancing user understanding.

@RDPerera RDPerera requested a review from chathurace as a code owner August 2, 2024 02:16
@RDPerera RDPerera changed the title Fix JSON to EDI Data Binding Fix JSON to EDI Data Binding in REST client Aug 2, 2024
@RDPerera RDPerera merged commit 7aee741 into ballerina-platform:main Aug 2, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Data Binding Issue with JSON to EDI Conversion in EDI tool
2 participants