Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for Invalid Package Name Error During Package Generation #53

Merged
merged 1 commit into from
Aug 1, 2024

Conversation

RDPerera
Copy link
Member

@RDPerera RDPerera commented Aug 1, 2024

Fixes: ballerina-platform/ballerina-library#6804

Issue Addressed:
This PR addresses the issue related to invalid package names during the package generation process when uppercase letters are present in the organization name. The error message encountered was:

Invalid package name. Package name should be in the format orgname/libname

Problem Description:
The package generation command fails if the organization name contains uppercase letters. For example, the following command results in an error:

bal edi libgen -p MyOrg/porder -i MyOrg/schemas -o MyOrg/lib

However, the command works as expected when the organization name is in lowercase:

bal edi libgen -p myorg/porder -i MyOrg/schemas -o myorg/lib

Solution:
This PR modifies the package validation logic to allow uppercase letters in the organization name, ensuring that the package generation process can handle organization names with uppercase letters without resulting in an error.

@RDPerera RDPerera requested a review from chathurace as a code owner August 1, 2024 08:08
@RDPerera RDPerera requested review from aashikam and niveathika August 1, 2024 08:21
@RDPerera RDPerera merged commit 0d03491 into ballerina-platform:main Aug 1, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Invalid Package Name Error During Package Generation
2 participants