Fix minOccurrences and maxOccurrences Handling in X12 to Ballerina Schema Conversion
#51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aashikam
reviewed
Jul 5, 2024
|
Tested for X12 810, 850 examples, and works as expected. |
niveathika
approved these changes
Jul 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Fixes: ballerina-platform/ballerina-library#6658 , ballerina-platform/ballerina-library#6610
This PR addresses two issues in the EDI tool:
minOccurrencesandmaxOccurrencesin Schema.json from X12 XSD Files:This fix resolves an issue where maxOccurrences/minOccurrences values from X12 XSD files were not accurately converted into schema.json, leading all values to default to 1 irrespective of the defined occurrences in the XSD.
This is a part of the sample X12 file;
Before Fix: Values of maxOccurrences and minOccurrences are not properly converted into Ballerina EDI schema.
After Fix: The same segment now correctly converts to schema.json with maxOccurrences and minOccurrences.
2. Enabling Documentation Comments in Generated Code:
Add documentation comments to the automatically generated public functions, enhancing the developer experience of the connector user.
Before Fix:
After Fix: