-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix process load test results workflow #6869
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I am -1 for this. We have discussed this previously as well. If a load test PR was failed due to a GitHub issue, we will lose that load test result because of this. The recommended way is to module owners to manually handle this (or maybe we can come up with a way to automate this, but I'm not sure). Manually handling:
|
Ack, will remove the deleting part. May be we can send a notification to a notification chat group with the library team members, so that they can address it asap |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
+1 for sending a message.
Since the workflows are failing currently in the merge PR step, I will merge this change and test. Sending notification on failure will be addressed separately |
Purpose
The load-tests has been failing for some time due to the following issue:
load-test-results
branch which is not sync with the master, which makes the push branch step failIn this PR, the above issues has been addressed with the following changes: