[IDEA Plugin] Test Implementation - Milestone #1 #9639
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NipunaRanasinghe
force-pushed
the
idea-tests
branch
from
feaefe5 to
caa4d3a
Compare
Shan1024
reviewed
Jul 30, 2018
| //This flag is used to include/filter BBE testerina files for the formatting testing | ||
| boolean includeTests = false; | ||
| Path path = Paths.get(getTestDataPath()); | ||
| doTestBBEDirectory(path, includeTests); |
There was a problem hiding this comment.
Remove the unnecessary variable includeTests since it is always true.
Shan1024
requested changes
Jul 30, 2018
| */ | ||
| public class BallerinaLexerTest extends LexerTestCase { | ||
|
|
||
| private final String testDataPath = "../../composer/modules/integration-tests/src/test/resources/ballerina" |
There was a problem hiding this comment.
Final variables should be capitalized.
| if (!path.toFile().exists()) { | ||
| throw new FileNotFoundException(path.toString()); | ||
| } | ||
| doTestDirectory(path, includeTests); |
There was a problem hiding this comment.
Remove unnecessary variable includeTests.
| return "src/test/resources/testData/formatting/BBE"; | ||
| } | ||
|
|
||
| //this test validates the formatting for the ballerina-by-examples |
There was a problem hiding this comment.
Capitalize the first letter and add a space after that.
There was a problem hiding this comment.
Where exactly you have done this?
| File resource = path.toFile(); | ||
| if (resource.exists()) { | ||
| if (resource.isFile() && resource.getName().endsWith(myFileExt)) { | ||
| doTest(resource, true); |
There was a problem hiding this comment.
Remove the 2nd parameter since it is always true.
| @@ -0,0 +1,6 @@ | |||
| #To run this sample, navigate to the directory that contains the | |||
There was a problem hiding this comment.
Removed the file
| @@ -0,0 +1,6 @@ | |||
| #To run this sample, navigate to the directory that contains the | |||
There was a problem hiding this comment.
Removed the file
Shan1024
approved these changes
Aug 2, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
This PR provides test implementation related to