Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve performance of array add operation and type checker #43701

Conversation

warunalakshitha
Copy link
Contributor

@warunalakshitha warunalakshitha commented Dec 11, 2024

Purpose

Fixes #43694

  • Read the Contributing Guide
  • Updated Change Log
  • Checked Tooling Support (#)
  • Added necessary tests
    • Unit Tests
    • Spec Conformance Tests
    • Integration Tests
    • Ballerina By Example Tests
  • Increased Test Coverage
  • Added necessary documentation
    • API documentation
    • Module documentation in Module.md files
    • Ballerina By Examples

Copy link
Member

@heshanpadmasiri heshanpadmasiri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@HindujaB HindujaB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@lochana-chathura lochana-chathura left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@warunalakshitha warunalakshitha force-pushed the perf_fix_semtype branch 2 times, most recently from fedce86 to 8b46143 Compare December 17, 2024 08:48
Copy link

codecov bot commented Dec 17, 2024

Codecov Report

Attention: Patch coverage is 76.47059% with 4 lines in your changes missing coverage. Please review.

Please upload report for BASE (2201.11.0-stage@109f6cc). Learn more about missing BASE report.
Report is 9 commits behind head on 2201.11.0-stage.

Files with missing lines Patch % Lines
...lerina/runtime/internal/values/ArrayValueImpl.java 71.42% 2 Missing and 2 partials ⚠️
Additional details and impacted files
@@                Coverage Diff                 @@
##             2201.11.0-stage   #43701   +/-   ##
==================================================
  Coverage                   ?   77.22%           
  Complexity                 ?    58799           
==================================================
  Files                      ?     3527           
  Lines                      ?   221752           
  Branches                   ?    28815           
==================================================
  Hits                       ?   171250           
  Misses                     ?    40841           
  Partials                   ?     9661           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@warunalakshitha warunalakshitha merged commit fbb3a35 into ballerina-platform:2201.11.0-stage Dec 19, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants