-
Notifications
You must be signed in to change notification settings - Fork 754
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Ballerina metrics logs observer #43615
Merged
NipunaMadhushan
merged 8 commits into
ballerina-platform:master
from
NipunaMadhushan:java21-metrics-logs
Dec 19, 2024
Merged
Add Ballerina metrics logs observer #43615
NipunaMadhushan
merged 8 commits into
ballerina-platform:master
from
NipunaMadhushan:java21-metrics-logs
Dec 19, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
...e/src/main/java/io/ballerina/runtime/observability/metrics/BallerinaMetricsLogsObserver.java
Outdated
Show resolved
Hide resolved
...e/src/main/java/io/ballerina/runtime/observability/metrics/BallerinaMetricsLogsObserver.java
Outdated
Show resolved
Hide resolved
...e/src/main/java/io/ballerina/runtime/observability/metrics/BallerinaMetricsLogsObserver.java
Outdated
Show resolved
Hide resolved
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #43615 +/- ##
============================================
- Coverage 77.47% 77.42% -0.06%
- Complexity 58512 58576 +64
============================================
Files 3434 3443 +9
Lines 218711 218978 +267
Branches 28918 28957 +39
============================================
+ Hits 169443 169536 +93
- Misses 39874 40023 +149
- Partials 9394 9419 +25 ☔ View full report in Codecov by Sentry. |
NipunaMadhushan
force-pushed
the
java21-metrics-logs
branch
from
November 22, 2024 04:35
689f6f4
to
4132840
Compare
chathurace
approved these changes
Dec 18, 2024
NipunaMadhushan
merged commit Dec 19, 2024
53f6d83
into
ballerina-platform:master
12 of 18 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
We are implementing log based metrics for Ballerina as a requirement for all WSO2 on-prem and SaaS products that need to use the same stack for observability. In order to retrieve metrics data using OpenSearch, we need to provide log based metrics which contain a format as follows.
[Time Stamp] protocol:<protocol_type> tagKey1:tagValue1 tagKey2:tagValue2 .. response_time:<value_in_seconds>
Fixes #43614
Approach
Samples
Remarks
Check List