-
Notifications
You must be signed in to change notification settings - Fork 755
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Master] Improve the order of completions for client resource access action statements #42551
Conversation
This PR has been open for more than 15 days with no activity. This will be closed in 3 days unless the |
@nipunayf Please update the PR with the master. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are we considering alphabetic order or any other order when re-ordering resource-function paths?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ATM there are no such explicit sorts, and we are preserving the order in which the user has defined the resource methods in the class.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #42551 +/- ##
============================================
+ Coverage 77.13% 77.19% +0.05%
- Complexity 51182 51285 +103
============================================
Files 2924 2929 +5
Lines 203973 204413 +440
Branches 26604 26663 +59
============================================
+ Hits 157338 157797 +459
+ Misses 38122 38055 -67
- Partials 8513 8561 +48 ☔ View full report in Codecov by Sentry. |
Purpose
Expanding on the work initiated in #41636, support has been broadened to client resource access action statements.
Fixes #42549
Samples
Check List