Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Master] Fix worker receive when the receiver successfully completes prior to the sync send #42478

Merged

Conversation

lochana-chathura
Copy link
Member

@lochana-chathura lochana-chathura commented Apr 4, 2024

Purpose

$subject.

  • receive-action is disallowed after a non-error return
  • receive-action is disallowed inside worker-on-fail-clause

Fixes #42476

Approach

n/a

Samples

n/a

Remarks

n/a

Check List

  • Read the Contributing Guide
  • Updated Change Log
  • Checked Tooling Support (#)
  • Added necessary tests
    • Unit Tests
    • Spec Conformance Tests
    • Integration Tests
    • Ballerina By Example Tests
  • Increased Test Coverage
  • Added necessary documentation
    • API documentation
    • Module documentation in Module.md files
    • Ballerina By Examples

@lochana-chathura lochana-chathura added the Team/CompilerFE All issues related to Language implementation and Compiler, this exclude run times. label Apr 4, 2024
@lochana-chathura lochana-chathura added this to the 2201.9.0 milestone Apr 4, 2024
Copy link

codecov bot commented Apr 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.81%. Comparing base (148286d) to head (ba610e5).
Report is 25 commits behind head on master.

❗ Current head ba610e5 differs from pull request most recent head e958607. Consider uploading reports for the commit e958607 to get more accurate results

Additional details and impacted files
@@             Coverage Diff              @@
##             master   #42478      +/-   ##
============================================
+ Coverage     76.80%   76.81%   +0.01%     
+ Complexity    53972    53950      -22     
============================================
  Files          2924     2924              
  Lines        203952   203852     -100     
  Branches      26597    26580      -17     
============================================
- Hits         156638   156592      -46     
+ Misses        38777    38724      -53     
+ Partials       8537     8536       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lochana-chathura lochana-chathura changed the title Fix worker receive related issues Fix worker receive when the receiver successfully completes prior to the sync send Apr 8, 2024
@lochana-chathura lochana-chathura changed the title Fix worker receive when the receiver successfully completes prior to the sync send [Master] Fix worker receive when the receiver successfully completes prior to the sync send Apr 9, 2024
@lochana-chathura lochana-chathura merged commit b2c6457 into ballerina-platform:master Apr 16, 2024
16 checks passed
@lochana-chathura lochana-chathura deleted the fix-worker branch April 16, 2024 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Team/CompilerFE All issues related to Language implementation and Compiler, this exclude run times.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Worker code hangs when message passing with sync-send and receiver terminates with a non-error value
2 participants