Support new options in xml conversion

[mindula]

Purpose

$title.

Fixes #42385

Approach

Describe how you are implementing the solutions along with the design details.

Samples

Provide high-level details about the samples related to this feature.

Remarks

List any other known issues, related PRs, TODO items, or any other notes related to the PR.

Check List

• Read the Contributing Guide
• Updated Change Log
• Checked Tooling Support (#)
• Added necessary tests
  • Unit Tests
  • Spec Conformance Tests
  • Integration Tests
  • Ballerina By Example Tests
• Increased Test Coverage
• Added necessary documentation
  • API documentation
  • Module documentation in Module.md files
  • Ballerina By Examples

[CLAassistant]

All committers have signed the CLA.

[prakanth97]

Build failed due to the checkstyle failure, can you take a look?

[prakanth97]

This PR did not include tests. Right? Shall we add considerable amount of tests for the changes.

[hasithaa]

@prakanth97 @mindula Do we need a config for explicitly adding attributes? I guess, currently we add the annotation by default. But runtime logic doesn't depend on this annotation. So someone can decide to omit it. Having a way to configure the behavior useful. But this can later.

[mindula]

@prakanth97 @mindula Do we need a config for explicitly adding attributes? I guess, currently we add the annotation by default. But runtime logic doesn't depend on this annotation. So someone can decide to omit it. Having a way to configure the behavior useful. But this can later.

Are you suggesting to add another configuration option to include attributes or not?

example:

<book>
    <title lang="en">string</title>
</book>

Without attributes

@xmldata:Name {value: "book"}
type Book record {
    string title;
};

With attributes

type Title record {
    string \#content;
    @xmldata:Attribute
    string lang;
};

@xmldata:Name {value: "book"}
type Book record {
    Title title;
};

[codecov]

Codecov Report

Attention: Patch coverage is 92.30769% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 76.74%. Comparing base (1874440) to head (8a3614e).
Report is 278 commits behind head on master.

Files	Patch %	Lines
...ina/xmltorecordconverter/XMLToRecordConverter.java	92.30%	0 Missing and 4 partials ⚠️

Additional details and impacted files

@@              Coverage Diff              @@
##             master   #42440       +/-   ##
=============================================
+ Coverage      0.00%   76.74%   +76.74%     
- Complexity        0    53828    +53828     
=============================================
  Files             9     2913     +2904     
  Lines            35   203404   +203369     
  Branches          0    26525    +26525     
=============================================
+ Hits              0   156107   +156107     
- Misses           35    38764    +38729     
- Partials          0     8533     +8533     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[prakanth97]

<book xmlns="http://example.com/book">
    <id>601970</id>
    <title>string</title>
    <author>string</author>
</book>

the name space is applied to all the elements and the attribute in the child of book and element book as well.

Hence the expected record should be

@xmldata:Namespace {uri: "http://example.com/book"}
@xmldata:Name {value: "book"}
type Book record {
    @xmldata:Namespace {uri: "http://example.com/book"}
    int id;
    @xmldata:Namespace {uri: "http://example.com/book"}
    string title;
    @xmldata:Namespace {uri: "http://example.com/book"}
    string author;
};

But what we generate at the moment is

@xmldata:Name {value: "book"}
type Book record {
    int id;
    string title;
    string author;
    @xmldata:Attribute
    string 'xmlns;
};

This seems wrong.

[prakanth97]

We did not add the namespace annotation here, seems wrong

[prakanth97]

Shall we add a example where we have namespace for the attribute?

[prakanth97]

Shall we add few tests for disabling namespace?

[prakanth97]

LGTM