Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix error detail throwing NPE for cause() #42249

Merged

Conversation

HindujaB
Copy link
Contributor

Purpose

Describe the problems, issues, or needs driving this feature/fix and include links to related issues.

Fixes #42248

Approach

added a detail type

Samples

Provide high-level details about the samples related to this feature.

Remarks

List any other known issues, related PRs, TODO items, or any other notes related to the PR.

Check List

  • Read the Contributing Guide
  • Updated Change Log
  • Checked Tooling Support (#)
  • Added necessary tests
    • Unit Tests
    • Spec Conformance Tests
    • Integration Tests
    • Ballerina By Example Tests
  • Increased Test Coverage
  • Added necessary documentation
    • API documentation
    • Module documentation in Module.md files
    • Ballerina By Examples

Copy link

codecov bot commented Feb 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.70%. Comparing base (559f3b8) to head (3c8ebcd).
Report is 104 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master   #42249      +/-   ##
============================================
- Coverage     76.71%   76.70%   -0.01%     
- Complexity    53085    53086       +1     
============================================
  Files          2882     2882              
  Lines        200043   200044       +1     
  Branches      26050    26050              
============================================
- Hits         153455   153449       -6     
- Misses        38138    38145       +7     
  Partials       8450     8450              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@HindujaB HindujaB changed the title [WIP] Fix error detail throwing NPE for cause() Fix error detail throwing NPE for cause() Mar 1, 2024
@HindujaB HindujaB requested a review from gabilang March 1, 2024 04:39
@HindujaB HindujaB added the Team/jBallerina All the issues related to BIR, JVM backend code generation and runtime label Mar 1, 2024
Copy link
Contributor

@gabilang gabilang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@warunalakshitha warunalakshitha merged commit 2ce4236 into ballerina-platform:master Mar 7, 2024
17 of 18 checks passed
@HindujaB HindujaB deleted the fix-error-detail branch March 8, 2024 04:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Team/jBallerina All the issues related to BIR, JVM backend code generation and runtime
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: NPE thrown for cause() calls for errors created from API
3 participants