-
Notifications
You must be signed in to change notification settings - Fork 756
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix error detail throwing NPE for cause()
#42249
Merged
warunalakshitha
merged 4 commits into
ballerina-platform:master
from
HindujaB:fix-error-detail
Mar 7, 2024
Merged
Fix error detail throwing NPE for cause()
#42249
warunalakshitha
merged 4 commits into
ballerina-platform:master
from
HindujaB:fix-error-detail
Mar 7, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #42249 +/- ##
============================================
- Coverage 76.71% 76.70% -0.01%
- Complexity 53085 53086 +1
============================================
Files 2882 2882
Lines 200043 200044 +1
Branches 26050 26050
============================================
- Hits 153455 153449 -6
- Misses 38138 38145 +7
Partials 8450 8450 ☔ View full report in Codecov by Sentry. |
HindujaB
changed the title
[WIP] Fix error detail throwing NPE for
Fix error detail throwing NPE for Mar 1, 2024
cause()
cause()
HindujaB
added
the
Team/jBallerina
All the issues related to BIR, JVM backend code generation and runtime
label
Mar 1, 2024
tests/jballerina-unit-test/src/test/resources/test-src/runtime/api/errors/main.bal
Outdated
Show resolved
Hide resolved
gabilang
approved these changes
Mar 7, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
warunalakshitha
approved these changes
Mar 7, 2024
warunalakshitha
merged commit Mar 7, 2024
2ce4236
into
ballerina-platform:master
17 of 18 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Fixes #42248
Approach
added a detail type
Samples
Remarks
Check List