-
Notifications
You must be signed in to change notification settings - Fork 756
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cache repeated type calculations #42111
Cache repeated type calculations #42111
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #42111 +/- ##
=============================================
+ Coverage 0.00% 76.70% +76.70%
- Complexity 0 53055 +53055
=============================================
Files 9 2884 +2875
Lines 35 199997 +199962
Branches 0 26034 +26034
=============================================
+ Hits 0 153401 +153401
- Misses 35 38141 +38106
- Partials 0 8455 +8455 ☔ View full report in Codecov by Sentry. |
bvm/ballerina-runtime/src/main/java/io/ballerina/runtime/api/types/Type.java
Show resolved
Hide resolved
bvm/ballerina-runtime/src/main/java/io/ballerina/runtime/api/types/Type.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with only some minor suggestions
bvm/ballerina-runtime/src/main/java/io/ballerina/runtime/api/types/Type.java
Outdated
Show resolved
Hide resolved
bvm/ballerina-runtime/src/main/java/io/ballerina/runtime/api/types/Type.java
Outdated
Show resolved
Hide resolved
bvm/ballerina-runtime/src/main/java/io/ballerina/runtime/api/types/Type.java
Outdated
Show resolved
Hide resolved
bvm/ballerina-runtime/src/main/java/io/ballerina/runtime/api/types/Type.java
Outdated
Show resolved
Hide resolved
07b5fe5
to
22849d7
Compare
Co-authored-by: Hinduja Balasubramaniyam <[email protected]>
22849d7
to
b044eba
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Purpose
Reduce runtime type checker overhead by caching repeated type calculations
Part of #42000
Approach
Samples
Remarks
Check List