Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cache repeated type calculations #42111

Conversation

heshanpadmasiri
Copy link
Member

Purpose

Reduce runtime type checker overhead by caching repeated type calculations

Part of #42000

Approach

Describe how you are implementing the solutions along with the design details.

Samples

Provide high-level details about the samples related to this feature.

Remarks

List any other known issues, related PRs, TODO items, or any other notes related to the PR.

Check List

  • Read the Contributing Guide
  • Updated Change Log
  • Checked Tooling Support (#)
  • Added necessary tests
    • Unit Tests
    • Spec Conformance Tests
    • Integration Tests
    • Ballerina By Example Tests
  • Increased Test Coverage
  • Added necessary documentation
    • API documentation
    • Module documentation in Module.md files
    • Ballerina By Examples

Copy link

codecov bot commented Feb 5, 2024

Codecov Report

Attention: 6 lines in your changes are missing coverage. Please review.

Comparison is base (0823dc9) 0.00% compared to head (b044eba) 76.70%.
Report is 19 commits behind head on master.

Files Patch % Lines
...main/java/io/ballerina/runtime/api/types/Type.java 0.00% 4 Missing ⚠️
.../main/java/org/ballerinalang/docgen/Generator.java 50.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##             master   #42111       +/-   ##
=============================================
+ Coverage      0.00%   76.70%   +76.70%     
- Complexity        0    53055    +53055     
=============================================
  Files             9     2884     +2875     
  Lines            35   199997   +199962     
  Branches          0    26034    +26034     
=============================================
+ Hits              0   153401   +153401     
- Misses           35    38141    +38106     
- Partials          0     8455     +8455     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lochana-chathura lochana-chathura added this to the 2201.9.0 milestone Feb 12, 2024
HindujaB
HindujaB previously approved these changes Feb 12, 2024
Copy link
Contributor

@HindujaB HindujaB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with only some minor suggestions

Co-authored-by: Hinduja Balasubramaniyam <[email protected]>
Copy link
Contributor

@HindujaB HindujaB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@heshanpadmasiri heshanpadmasiri merged commit b5c6a95 into ballerina-platform:master Feb 19, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants