Remove generating observability-symbols.jar #42002
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NipunaMadhushan
requested review from
hevayo,
sameerajayasoma and
hasithaa
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #42002 +/- ##
============================================
+ Coverage 76.62% 76.67% +0.04%
- Complexity 52803 53003 +200
============================================
Files 2880 2881 +1
Lines 199139 199870 +731
Branches 25882 26016 +134
============================================
+ Hits 152590 153243 +653
- Misses 38116 38165 +49
- Partials 8433 8462 +29 ☔ View full report in Codecov by Sentry. |
|
This PR has been open for more than 15 days with no activity. This will be closed in 3 days unless the |
| @@ -133,12 +131,6 @@ private JBallerinaBackend(PackageCompilation packageCompilation, JvmTarget jdkVe | |||
| this.compilerContext = projectEnvContext.getService(CompilerContext.class); | |||
| this.interopValidator = InteropValidator.getInstance(compilerContext); | |||
| this.jvmCodeGenerator = CodeGenerator.getInstance(compilerContext); | |||
| // TODO: Move to a compiler extension once Compiler revamp is complete | |||
| if (packageContext.compilationOptions().observabilityIncluded()) { | |||
There was a problem hiding this comment.
Do we need observabilityIncluded method in packageContext compiler options? Can we remove that?
There was a problem hiding this comment.
@warunalakshitha We need it to enable tracing and metrics.
warunalakshitha
approved these changes
Feb 29, 2024
HindujaB
approved these changes
Feb 29, 2024
MaryamZi
approved these changes
Feb 29, 2024
keizer619
approved these changes
Feb 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Remove generating
<module-name>-observability-symbols.jarwhen observability is enabled since the jar is not used anymore and OOM issues occur as well.Fixes #42001
Approach
Samples
Remarks
Check List