-
Notifications
You must be signed in to change notification settings - Fork 753
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix formatting of comments above import declarations #41481
Fix formatting of comments above import declarations #41481
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #41481 +/- ##
=============================================
+ Coverage 0.00% 76.64% +76.64%
- Complexity 0 53691 +53691
=============================================
Files 9 2907 +2898
Lines 35 203057 +203022
Branches 0 26470 +26470
=============================================
+ Hits 0 155624 +155624
- Misses 35 38934 +38899
- Partials 0 8499 +8499 ☔ View full report in Codecov by Sentry. |
This PR has been open for more than 15 days with no activity. This will be closed in 3 days unless the |
...er/modules/formatter-core/src/main/java/org/ballerinalang/formatter/core/FormatterUtils.java
Outdated
Show resolved
Hide resolved
...er/modules/formatter-core/src/main/java/org/ballerinalang/formatter/core/FormatterUtils.java
Outdated
Show resolved
Hide resolved
...er/modules/formatter-core/src/main/java/org/ballerinalang/formatter/core/FormatterUtils.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This PR has been open for more than 15 days with no activity. This will be closed in 3 days unless the |
This PR has been open for more than 15 days with no activity. This will be closed in 3 days unless the |
This PR has been open for more than 15 days with no activity. This will be closed in 3 days unless the |
This PR has been open for more than 15 days with no activity. This will be closed in 3 days unless the |
This PR has been open for more than 15 days with no activity. This will be closed in 3 days unless the |
e98deca
to
c5b626a
Compare
// Copyright (c) 2023 WSO2 LLC. (http://www.wso2.org) All Rights Reserved.
//
// WSO2 LLC. licenses this file to you under the Apache License,
// Version 2.0 (the "License"); you may not use this file except
// in compliance with the License.
// You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in writing,
// software distributed under the License is distributed on an
// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
// KIND, either express or implied. See the License for the
// specific language governing permissions and limitations
// under the License.
// check this
import ballerinax/twilio as _;
import ballerina/jballerina.java as _; adds an empty line between
int i = 1; and formatted the file (all via VSCode). This removed my changes and added // Copyright (c) 2023 WSO2 LLC. (http://www.wso2.org) All Rights Reserved.
//
// WSO2 LLC. licenses this file to you under the Apache License,
// Version 2.0 (the "License"); you may not use this file except
// in compliance with the License.
// You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in writing,
// software distributed under the License is distributed on an
// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
// KIND, either express or implied. See the License for the
// specific language governing permissions and limitations
// under the License.
// check this
import ballerina/jballerina.java as _;
import ballerinax/twilio as _; |
A newline is added separating the top most comments and the top most import node. Thus this is the expected behaviour.
This might not be relevant to this change and this is may be relevant to this |
...er/modules/formatter-core/src/main/java/org/ballerinalang/formatter/core/FormatterUtils.java
Outdated
Show resolved
Hide resolved
...er/modules/formatter-core/src/main/java/org/ballerinalang/formatter/core/FormatterUtils.java
Outdated
Show resolved
Hide resolved
...er/modules/formatter-core/src/main/java/org/ballerinalang/formatter/core/FormatterUtils.java
Show resolved
Hide resolved
...er/modules/formatter-core/src/main/java/org/ballerinalang/formatter/core/FormatterUtils.java
Outdated
Show resolved
Hide resolved
...es/formatter-core/src/main/java/org/ballerinalang/formatter/core/FormattingTreeModifier.java
Outdated
Show resolved
Hide resolved
...dules/formatter-core/src/test/resources/declarations/import/assert/import_declaration_10.bal
Show resolved
Hide resolved
...dules/formatter-core/src/test/resources/declarations/import/source/import_declaration_10.bal
Outdated
Show resolved
Hide resolved
...es/formatter-core/src/main/java/org/ballerinalang/formatter/core/FormattingTreeModifier.java
Outdated
Show resolved
Hide resolved
...es/formatter-core/src/main/java/org/ballerinalang/formatter/core/FormattingTreeModifier.java
Show resolved
Hide resolved
...es/formatter-core/src/main/java/org/ballerinalang/formatter/core/FormattingTreeModifier.java
Show resolved
Hide resolved
...core/src/test/java/org/ballerinalang/formatter/core/declarations/ImportDeclarationsTest.java
Outdated
Show resolved
Hide resolved
...dules/formatter-core/src/test/resources/declarations/import/assert/import_declaration_10.bal
Outdated
Show resolved
Hide resolved
...er/modules/formatter-core/src/main/java/org/ballerinalang/formatter/core/FormatterUtils.java
Outdated
Show resolved
Hide resolved
...er/modules/formatter-core/src/main/java/org/ballerinalang/formatter/core/FormatterUtils.java
Outdated
Show resolved
Hide resolved
...er/modules/formatter-core/src/main/java/org/ballerinalang/formatter/core/FormatterUtils.java
Outdated
Show resolved
Hide resolved
...er/modules/formatter-core/src/main/java/org/ballerinalang/formatter/core/FormatterUtils.java
Show resolved
Hide resolved
...er/modules/formatter-core/src/main/java/org/ballerinalang/formatter/core/FormatterUtils.java
Outdated
Show resolved
Hide resolved
ed8c29d
to
ff84e47
Compare
304c25d
to
9ff8588
Compare
9ff8588
to
f45f13c
Compare
Purpose
Fixes #41478
Fixes #41613
Approach
Samples
Remarks
Check List