-
Notifications
You must be signed in to change notification settings - Fork 755
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Do not expose runtime.internal
imports in runtime.api
package
#40212
Do not expose runtime.internal
imports in runtime.api
package
#40212
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #40212 +/- ##
============================================
- Coverage 80.67% 77.26% -3.41%
+ Complexity 76007 54361 -21646
============================================
Files 3409 3349 -60
Lines 260999 201712 -59287
Branches 45660 25889 -19771
============================================
- Hits 210552 155854 -54698
+ Misses 41621 37420 -4201
+ Partials 8826 8438 -388
☔ View full report in Codecov by Sentry. |
bvm/ballerina-runtime/src/main/java/io/ballerina/runtime/api/values/BRegexpValue.java
Outdated
Show resolved
Hide resolved
bvm/ballerina-runtime/src/main/java/io/ballerina/runtime/api/async/StrandMetadata.java
Show resolved
Hide resolved
Created #40337 to change |
|
bvm/ballerina-runtime/src/main/java/io/ballerina/runtime/api/Environment.java
Outdated
Show resolved
Hide resolved
bvm/ballerina-runtime/src/main/java/io/ballerina/runtime/internal/util/StringUtils.java
Outdated
Show resolved
Hide resolved
bvm/ballerina-runtime/src/main/java/io/ballerina/runtime/internal/util/StringUtils.java
Outdated
Show resolved
Hide resolved
bvm/ballerina-runtime/src/main/java/io/ballerina/runtime/internal/types/BTypedescType.java
Show resolved
Hide resolved
bvm/ballerina-runtime/src/main/java/io/ballerina/runtime/api/Environment.java
Outdated
Show resolved
Hide resolved
bvm/ballerina-runtime/src/main/java/io/ballerina/runtime/api/async/Callback.java
Outdated
Show resolved
Hide resolved
bvm/ballerina-runtime/src/main/java/io/ballerina/runtime/api/types/HandleType.java
Outdated
Show resolved
Hide resolved
bvm/ballerina-runtime/src/main/java/io/ballerina/runtime/api/values/BTypedesc.java
Show resolved
Hide resolved
bvm/ballerina-runtime/src/main/java/io/ballerina/runtime/internal/types/BHandleType.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's add all deprecated methods to release note. IMO we need to add all abstract classes as breaking change in release note with note saying creating instances of those are not corrected.
bvm/ballerina-runtime/src/main/java/io/ballerina/runtime/api/PredefinedTypes.java
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Purpose
$title
Fixes #38077
Approach
Samples
Remarks
Check List