Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not expose runtime.internal imports in runtime.api package #40212

Conversation

Nadeeshan96
Copy link
Contributor

Purpose

Describe the problems, issues, or needs driving this feature/fix and include links to related issues.

$title
Fixes #38077

Approach

Describe how you are implementing the solutions along with the design details.

Samples

Provide high-level details about the samples related to this feature.

Remarks

List any other known issues, related PRs, TODO items, or any other notes related to the PR.

Check List

  • Read the Contributing Guide
  • Updated Change Log
  • Checked Tooling Support (#)
  • Added necessary tests
    • Unit Tests
    • Spec Conformance Tests
    • Integration Tests
    • Ballerina By Example Tests
  • Increased Test Coverage
  • Added necessary documentation
    • API documentation
    • Module documentation in Module.md files
    • Ballerina By Examples

@Nadeeshan96 Nadeeshan96 added the Team/jBallerina All the issues related to BIR, JVM backend code generation and runtime label Apr 12, 2023
@codecov
Copy link

codecov bot commented Apr 17, 2023

Codecov Report

Patch coverage: 82.60% and project coverage change: -3.41 ⚠️

Comparison is base (71a0cb0) 80.67% compared to head (0485e50) 77.26%.

Additional details and impacted files
@@             Coverage Diff              @@
##             master   #40212      +/-   ##
============================================
- Coverage     80.67%   77.26%   -3.41%     
+ Complexity    76007    54361   -21646     
============================================
  Files          3409     3349      -60     
  Lines        260999   201712   -59287     
  Branches      45660    25889   -19771     
============================================
- Hits         210552   155854   -54698     
+ Misses        41621    37420    -4201     
+ Partials       8826     8438     -388     
Impacted Files Coverage Δ
...java/io/ballerina/runtime/api/PredefinedTypes.java 100.00% <ø> (ø)
...io/ballerina/runtime/api/async/StrandMetadata.java 100.00% <ø> (ø)
...lerina/runtime/api/constants/RuntimeConstants.java 100.00% <ø> (+5.26%) ⬆️
...ballerina/runtime/api/constants/TypeConstants.java 100.00% <ø> (+33.33%) ⬆️
...o/ballerina/runtime/api/creators/ErrorCreator.java 64.28% <ø> (ø)
...io/ballerina/runtime/api/creators/TypeCreator.java 68.42% <ø> (ø)
...o/ballerina/runtime/api/creators/ValueCreator.java 62.06% <ø> (-1.15%) ⬇️
...java/io/ballerina/runtime/api/types/ArrayType.java 100.00% <ø> (ø)
...java/io/ballerina/runtime/api/types/Parameter.java 58.33% <ø> (ø)
...java/io/ballerina/runtime/api/utils/TypeUtils.java 20.00% <ø> (+0.82%) ⬆️
... and 55 more

... and 462 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Nadeeshan96 Nadeeshan96 marked this pull request as ready for review April 18, 2023 03:24
@Nadeeshan96
Copy link
Contributor Author

Created #40337 to change Runtime, Future, Environment APIs to interfaces.

@Nadeeshan96
Copy link
Contributor Author

CI Full Build Ubuntu / Build Stdlib Level (6) is failing due to ballerina-platform/ballerina-library#4405. Will fix that.

Copy link
Contributor

@warunalakshitha warunalakshitha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's add all deprecated methods to release note. IMO we need to add all abstract classes as breaking change in release note with note saying creating instances of those are not corrected.

@Nadeeshan96 Nadeeshan96 added this to the 2201.6.0 milestone May 17, 2023
@warunalakshitha warunalakshitha added the Fix/BreakingChange Fix containing a backward incompatible change. label May 17, 2023
Copy link
Contributor

@warunalakshitha warunalakshitha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@warunalakshitha warunalakshitha merged commit 31375ed into ballerina-platform:master May 18, 2023
@Nadeeshan96 Nadeeshan96 deleted the master-remove-imports-38077 branch May 19, 2023 04:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Fix/BreakingChange Fix containing a backward incompatible change. Team/jBallerina All the issues related to BIR, JVM backend code generation and runtime
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Remove io.ballerina.runtime.internal imports from io.ballerina.runtime.api package.
4 participants