Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement bir, codegen and runtime changes for spread operator #35696

Conversation

lochana-chathura
Copy link
Member

Purpose

$subject.

Fixes subtask: Implement bir, codegen and runtime changes of #35178

Approach

N/A

Samples

N/A

Remarks

N/A

Check List

  • Read the Contributing Guide
  • Updated Change Log
  • Checked Tooling Support (#)
  • Added necessary tests
    • Unit Tests
    • Spec Conformance Tests
    • Integration Tests
    • Ballerina By Example Tests
  • Increased Test Coverage
  • Added necessary documentation
    • API documentation
    • Module documentation in Module.md files
    • Ballerina By Examples

@lochana-chathura lochana-chathura added the Team/CompilerFE All issues related to Language implementation and Compiler, this exclude run times. label Apr 6, 2022
@codecov
Copy link

codecov bot commented Apr 7, 2022

Codecov Report

Merging #35696 (3d30e38) into spread-operator (ab9f63b) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@                Coverage Diff                 @@
##             spread-operator   #35696   +/-   ##
==================================================
  Coverage              74.28%   74.29%           
- Complexity             46781    46804   +23     
==================================================
  Files                   3145     3145           
  Lines                 181774   181858   +84     
  Branches               23527    23541   +14     
==================================================
+ Hits                  135035   135113   +78     
- Misses                 38917    38923    +6     
  Partials                7822     7822           
Impacted Files Coverage Δ
...llerinalang/compiler/bir/codegen/JvmConstants.java 100.00% <ø> (ø)
...lerina/runtime/internal/values/ArrayValueImpl.java 86.31% <100.00%> (+0.15%) ⬆️
...runtime/internal/values/ListInitialValueEntry.java 100.00% <100.00%> (ø)
...lerina/runtime/internal/values/TupleValueImpl.java 70.92% <100.00%> (+1.63%) ⬆️
...va/org/wso2/ballerinalang/compiler/bir/BIRGen.java 90.81% <100.00%> (+0.02%) ⬆️
...nalang/compiler/bir/codegen/JvmInstructionGen.java 88.96% <100.00%> (+0.09%) ⬆️
...wso2/ballerinalang/compiler/bir/model/BIRNode.java 86.19% <100.00%> (+0.41%) ⬆️
...erinalang/compiler/bir/model/BIRNonTerminator.java 89.02% <100.00%> (ø)
...erinalang/compiler/bir/optimizer/BIROptimizer.java 95.89% <100.00%> (ø)
...lang/compiler/bir/writer/BIRInstructionWriter.java 94.07% <100.00%> (ø)
... and 12 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 54ddc30...3d30e38. Read the comment docs.

Copy link
Contributor

@lasinicl lasinicl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested. Changes LGTM.

@KavinduZoysa
Copy link
Contributor

KavinduZoysa commented Apr 8, 2022

Changes are okay,
Shall we add a few tests which use the spread operator in module-init-var-decl?

Copy link
Member

@pcnfernando pcnfernando left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pcnfernando pcnfernando merged commit 3fc300b into ballerina-platform:spread-operator Apr 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Team/CompilerFE All issues related to Language implementation and Compiler, this exclude run times.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants