-
Notifications
You must be signed in to change notification settings - Fork 754
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement bir, codegen and runtime changes for spread operator #35696
Implement bir, codegen and runtime changes for spread operator #35696
Conversation
…rm/ballerina-lang into spread-op-desugar
5037749
to
770d67b
Compare
Codecov Report
@@ Coverage Diff @@
## spread-operator #35696 +/- ##
==================================================
Coverage 74.28% 74.29%
- Complexity 46781 46804 +23
==================================================
Files 3145 3145
Lines 181774 181858 +84
Branches 23527 23541 +14
==================================================
+ Hits 135035 135113 +78
- Misses 38917 38923 +6
Partials 7822 7822
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested. Changes LGTM.
Changes are okay, |
bvm/ballerina-runtime/src/main/java/io/ballerina/runtime/internal/values/ArrayValueImpl.java
Show resolved
Hide resolved
bvm/ballerina-runtime/src/main/java/io/ballerina/runtime/internal/values/TupleValueImpl.java
Outdated
Show resolved
Hide resolved
compiler/ballerina-lang/src/main/java/org/wso2/ballerinalang/compiler/desugar/Desugar.java
Outdated
Show resolved
Hide resolved
Co-authored-by: Chiran Fernando <[email protected]>
compiler/ballerina-lang/src/main/java/org/wso2/ballerinalang/compiler/desugar/Desugar.java
Show resolved
Hide resolved
...r/ballerina-lang/src/main/java/org/wso2/ballerinalang/compiler/semantics/analyzer/Types.java
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Purpose
$subject.
Fixes subtask: Implement bir, codegen and runtime changes of #35178
Approach
N/A
Samples
N/A
Remarks
N/A
Check List