Add type checker support for spread operator in list-constructor-expr
#35601
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rm/ballerina-lang into spead-opt-type-check � Conflicts: � compiler/ballerina-lang/src/main/java/org/wso2/ballerinalang/compiler/parser/BLangNodeBuilder.java
lochana-chathura
added
the
Team/CompilerFE
Codecov Report
@@ Coverage Diff @@
## spread-operator #35601 +/- ##
=====================================================
+ Coverage 74.25% 74.28% +0.02%
- Complexity 46721 46781 +60
=====================================================
Files 3145 3145
Lines 181591 181774 +183
Branches 23482 23527 +45
=====================================================
+ Hits 134845 135035 +190
+ Misses 38919 38917 -2
+ Partials 7827 7822 -5
Continue to review full report at Codecov.
|
lochana-chathura
force-pushed
the
spead-opt-type-check
branch
from
77c4ac1 to
23d833e
Compare
lochana-chathura
force-pushed
the
spead-opt-type-check
branch
from
5cc38b0 to
ffff679
Compare
lochana-chathura
requested review from
sameerajayasoma and
hasithaa
as code owners
pcnfernando
reviewed
Apr 6, 2022
...erina-lang/src/main/java/org/wso2/ballerinalang/compiler/semantics/analyzer/TypeChecker.java
Outdated
Show resolved
Hide resolved
...erina-lang/src/main/java/org/wso2/ballerinalang/compiler/semantics/analyzer/TypeChecker.java
Show resolved
Hide resolved
...erina-lang/src/main/java/org/wso2/ballerinalang/compiler/semantics/analyzer/TypeChecker.java
Outdated
Show resolved
Hide resolved
...erina-lang/src/main/java/org/wso2/ballerinalang/compiler/semantics/analyzer/TypeChecker.java
Outdated
Show resolved
Hide resolved
gimantha
reviewed
Apr 7, 2022
...erina-lang/src/main/java/org/wso2/ballerinalang/compiler/semantics/analyzer/TypeChecker.java
Show resolved
Hide resolved
gimantha
reviewed
Apr 7, 2022
...erina-lang/src/main/java/org/wso2/ballerinalang/compiler/semantics/analyzer/TypeChecker.java
Show resolved
Hide resolved
gimantha
reviewed
Apr 7, 2022
...rc/test/java/org/ballerinalang/test/expressions/listconstructor/ListConstructorExprTest.java
Show resolved
Hide resolved
pcnfernando
reviewed
Apr 7, 2022
| @@ -61,10 +61,12 @@ public void diagnosticsTest() { | |||
| "inferred for '[1, p]'", 38, 35); | |||
| BAssertUtil.validateError(resultNegative, i++, "invalid list constructor expression: types cannot be " + | |||
| "inferred for '[a, 4]'", 41, 23); | |||
| BAssertUtil.validateError(resultNegative, i++, "tuple and expression size does not match", | |||
| BAssertUtil.validateError(resultNegative, i++, | |||
There was a problem hiding this comment.
In cases like
type Rec record {
int a;
};
function foo() {
[Rec1, int] a = []; //this should not throw no filler value error AFIU.
}There seems to be already this bug. The only difference is now we are getting this new error.
Created #35712
pcnfernando
approved these changes
Apr 7, 2022
13 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
$subject.
Fixes subtask: Implement type checker changes of #35178
Fixes: #34990
Approach
N/A
Samples
N/A
Remarks
N/A
Check List