Implement parser changes for spread operator in list-constructor-expr
#35386
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lochana-chathura
changed the title
list-constructor-expr
MaryamZi
added
the
Team/CompilerFE
lochana-chathura
added
the
Area/Parser
lochana-chathura
requested review from
hevayo,
mohanvive,
nadeeshaan,
sameerajayasoma and
hasithaa
as code owners
Codecov Report
@@ Coverage Diff @@
## spread-operator #35386 +/- ##
==================================================
Coverage ? 71.07%
Complexity ? 44941
==================================================
Files ? 3145
Lines ? 181591
Branches ? 23482
==================================================
Hits ? 129063
Misses ? 45301
Partials ? 7227 Continue to review full report at Codecov.
|
lochana-chathura
commented
Mar 9, 2022
...rina-parser/src/main/java/io/ballerina/compiler/internal/parser/tree/STSpreadMemberNode.java
Outdated
Show resolved
Hide resolved
gimantha
reviewed
Mar 15, 2022
...rc/main/java/io/ballerina/compiler/internal/parser/tree/STListConstructorExpressionNode.java
Outdated
Show resolved
Hide resolved
gimantha
reviewed
Mar 15, 2022
...rina-parser/src/main/java/io/ballerina/compiler/internal/parser/tree/STSpreadMemberNode.java
Outdated
Show resolved
Hide resolved
gimantha
reviewed
Mar 15, 2022
compiler/ballerina-parser/src/main/java/io/ballerina/compiler/syntax/tree/SpreadMemberNode.java
Outdated
Show resolved
Hide resolved
lochana-chathura
force-pushed
the
spread-opt
branch
from
439ccce to
c30d2bd
Compare
rdulmina
reviewed
Mar 15, 2022
...-parser/src/main/java/io/ballerina/compiler/internal/parser/BallerinaParserErrorHandler.java
Outdated
Show resolved
Hide resolved
rdulmina
reviewed
Mar 16, 2022
...er/ballerina-parser/src/main/java/io/ballerina/compiler/internal/parser/BallerinaParser.java
Outdated
Show resolved
Hide resolved
| .filter(expression -> this.matchedNode == expression) | ||
| .findFirst(); | ||
| if (expressionNode.isPresent() && expressionNode.get() instanceof ExpressionNode) { | ||
| return Optional.of((ExpressionNode) expressionNode.get()); | ||
| if (listMemberNode.isPresent() && listMemberNode.get() instanceof ExpressionNode) { |
There was a problem hiding this comment.
SpreadMemberNode will not be an instance of ExpressionNode will that be an issue here?
There was a problem hiding this comment.
Created #35507. @malinthar will send a fix separately once this is merged.
rdulmina
reviewed
Mar 21, 2022
...er/ballerina-parser/src/main/java/io/ballerina/compiler/internal/parser/BallerinaParser.java
Outdated
Show resolved
Hide resolved
lochana-chathura
force-pushed
the
spread-opt
branch
from
faa382d to
191a024
Compare
…ssionNode" This reverts commit 4bcdd66.
rdulmina
approved these changes
Mar 22, 2022
gimantha
reviewed
Mar 23, 2022
compiler/ballerina-parser/src/main/java/io/ballerina/compiler/syntax/tree/SpreadMemberNode.java
Outdated
Show resolved
Hide resolved
gimantha
reviewed
Mar 23, 2022
compiler/ballerina-parser/src/main/java/io/ballerina/compiler/syntax/tree/SpreadMemberNode.java
Outdated
Show resolved
Hide resolved
Co-authored-by: Gimantha Bandara <[email protected]>
lochana-chathura
force-pushed
the
spread-opt
branch
from
1f9e057 to
d6e2884
Compare
|
Looks good to me. |
13 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
$subject.
Fixes subtask: implement parser and error handler changes of #35178
Approach
Refer to #35351 (comment)
Samples
N/A
Remarks
N/A
Check List