Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce support for isolated functions #25761

Merged
merged 100 commits into from
Sep 15, 2020
Merged

Introduce support for isolated functions #25761

merged 100 commits into from
Sep 15, 2020

Conversation

MaryamZi
Copy link
Member

Purpose

$title.

Fixes #24907

Approach

A new phase is introduced for isolation function validation and inferring. In addition, the type checker now takes into account the isolated flag.

Remarks

Pending tasks - support isolated with function type descriptors and anonymous functions. #25565

Check List

  • Read the Contributing Guide
  • Updated Change Log
  • Checked Tooling Support (#)
  • Added necessary tests
    • Unit Tests
    • Spec Conformance Tests
    • Integration Tests
    • Ballerina By Example Tests
  • Increased Test Coverage
  • Added necessary documentation
    • API documentation
    • Module documentation in Module.md files
    • Ballerina By Examples

MaryamZi and others added 30 commits August 12, 2020 16:34
@MaryamZi
Add initial parser changes for isolated
9c9f8b1
@MaryamZi
Merge master
0f0c01d
@MaryamZi
Intro initial error handling for isolated
8ae4247
@MaryamZi
Merge master
8971f5a
@MaryamZi
Add positive parser tests for isolated
3d891d3
@MaryamZi
Add parser error recovery tests for isolated
9ee0c49
@MaryamZi
Resolve conflicts and merge master
979ba62
@MaryamZi
Introduce IsolationAnalyzer - Take I
997686f
@MaryamZi
Change isolation check to see if ref belongs to current invokable
5ac894b
@MaryamZi
Implement remaining visits and enable isolation analysis
d316399 
Also changes  to return only non-note diagnostics.
@MaryamZi
Add object method isolation analysis
ce1dfb5
@MaryamZi
Merge master
6222a6e
@MaryamZi
Rename the method that retrieves all non-note diagnostics
052690b
@MaryamZi
Fix parser tests
bc44fcd
@MaryamZi
Comment out logging note logs to the console
eb4457f
@MaryamZi
Perform isolation analysis w/out class var and fix error constr. anal…
596dc60 
…ysis
@MaryamZi
Add tests
eac7a71
@MaryamZi
Visit args for isolation analysis and add object method/service funct…
2b8a8f5 
…ion tests
@MaryamZi
Merge master
a576621
@MaryamZi
Fix BLangOnClause visit for upstream changes
2b71a45
@MaryamZi
Consider isolated flag for type-checking
c70ceb8
@MaryamZi
Merge master
f32adee
@MaryamZi
Use consume to parse the isolated keyword
becd1b0
@MaryamZi
Fix function string repr. and add tests for function typedescs/anon f…
70d40fe 
…uncs

The tests are commented out until support for isolated function typedescs and anon functions is added
@MaryamZi
Resolve conflicts and merge master
dbe90b3
@MaryamZi
Resolve conflicts and merge master
3537de0
@rdulmina
Merge branch 'add-isolated-funcs' of https://github.com/MaryamZi/ball…
3b3a61d 
…erina into add-isolated
@rdulmina
Merge branch 'master' of https://github.com/ballerina-platform/baller…
8b0d0d9 
…ina-lang into add-isolated
@rdulmina
Parser changes for func type and anon func.
2423ebc 
Parsing logic isolate support for function type desc and anonymous function expression.
@rdulmina
Error handler changes.
9d69365
rdulmina and others added 13 commits September 15, 2020 13:14
@rdulmina
Add parser tests.
8db0cd5
@rdulmina
Add jballerina unit test.
39d0acd
@rdulmina
Remove commented code segment.
c31ae84
@rdulmina
Add new line to EOF.
24b35a8
@rdulmina
Merge branch 'isolated-functions' of https://github.com/ballerina-pla…
c7ddcfc 
…tform/ballerina-lang into add-isolated
@MaryamZi
Implement IsolationAnalyzer visits for new nodes
d226de4
@MaryamZi
Merge pull request #25809 from MaryamZi/add-isolated-funcs
2344aa4 
Implement IsolationAnalyzer visits for new nodes
@MaryamZi
Fix match changes for isolation analysis
ed760e4
@MaryamZi
Merge pull request #25812 from MaryamZi/add-isolated-funcs
9799113 
Fix match changes for isolation analysis
@rdulmina
Restore isValidExprStart method.
8ada57b
@rdulmina
Merge branch 'isolated-functions' of https://github.com/ballerina-pla…
e630a0a 
…tform/ballerina-lang into add-isolated
@rdulmina
Merge remote-tracking branch 'origin/add-isolated' into add-isolated
01b6027 
# Conflicts:
#	compiler/ballerina-parser/src/main/java/io/ballerinalang/compiler/internal/parser/BallerinaParser.java
@MaryamZi
Merge pull request #25808 from rdulmina/add-isolated
97a187e 
Add trasactional support to func type desc and anon func.
@MaryamZi MaryamZi requested a review from hasithaa September 15, 2020 11:02
@hasithaa hasithaa merged commit 3aa817e into master Sep 15, 2020
@MaryamZi MaryamZi mentioned this pull request Sep 16, 2020
Closed
@BuddhiWathsala BuddhiWathsala mentioned this pull request Sep 16, 2020
Merged
@MaryamZi MaryamZi deleted the isolated-functions branch September 18, 2020 06:10
This was referenced Sep 18, 2020
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hasithaa hasithaa hasithaa approved these changes

Assignees
No one assigned
Labels
Team/CompilerFE All issues related to Language implementation and Compiler, this exclude run times.
Projects
None yet
Milestone
[SLP4] Ballerina Swan Lake - Preview 4
Development

Successfully merging this pull request may close these issues.

Add support for isolated functions
3 participants
@MaryamZi @hasithaa @rdulmina