-
Notifications
You must be signed in to change notification settings - Fork 755
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce breaking changes to toString()
method
#25738
Merged
pcnfernando
merged 71 commits into
ballerina-platform:master
from
mohanvive:tostring-impl
Sep 11, 2020
Merged
Introduce breaking changes to toString()
method
#25738
pcnfernando
merged 71 commits into
ballerina-platform:master
from
mohanvive:tostring-impl
Sep 11, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix tests to sync toString change
Fix types package after toString change
Add toString() for error type
Fix interop package after toString change
…ina-lang into master-new # Conflicts: # tests/jballerina-unit-test/src/test/resources/test-src/javainterop/basic/object_test.bal
Fix langlib tests
…a-lang into toString-cycles # Conflicts: # bvm/ballerina-runtime/src/main/java/org/ballerinalang/jvm/values/ErrorValue.java
mohanvive
changed the title
[WIP] Introduce breaking chances to
[WIP] Introduce breaking changes to Sep 11, 2020
toString()
methodtoString()
method
Add toString() for cycles
mohanvive
changed the title
[WIP] Introduce breaking changes to
Introduce breaking changes to Sep 11, 2020
toString()
methodtoString()
method
Fix links of tuples and xml items
Fix checkstyle issues
Fix java doc issues
gimantha
reviewed
Sep 11, 2020
bvm/ballerina-runtime/src/main/java/org/ballerinalang/jvm/values/ErrorValue.java
Show resolved
Hide resolved
gimantha
reviewed
Sep 11, 2020
bvm/ballerina-runtime/src/main/java/org/ballerinalang/jvm/values/MapValueImpl.java
Show resolved
Hide resolved
gimantha
reviewed
Sep 11, 2020
bvm/ballerina-runtime/src/main/java/org/ballerinalang/jvm/values/ArrayValueImpl.java
Show resolved
Hide resolved
…a-lang into master-new # Conflicts: # bvm/ballerina-runtime/src/main/java/org/ballerinalang/jvm/values/ArrayValueImpl.java # bvm/ballerina-runtime/src/main/java/org/ballerinalang/jvm/values/TableValueImpl.java
gimantha
previously approved these changes
Sep 11, 2020
pcnfernando
approved these changes
Sep 11, 2020
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
[Update after #25753 https://github.com//pull/25753]
Please find a few examples below,