Fix code suggestion for PR #23473 #24179
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Annotation value is restricted to true, map<anydata|readonly> or map<anydata|readonly>[] value. Changes will also make sure that annotation value is a read only clone of the given value. Therefore user cannot change annotation value via annotation access.
Uniformity for `readonly & T` and `T & readonly`. Chose `readonly & T`. Refactor java code logic. Instead of making fields readonly for implementations of abstract objects, whole object is made readonly.
MaryamZi
reviewed
Jun 16, 2020
| switch (expr.getKind()) { | ||
| case LITERAL: | ||
| case NUMERIC_LITERAL: | ||
| return true; | ||
| case INVOCATION: | ||
| BLangInvocation invocation = (BLangInvocation) expr; | ||
| if (invocation.name.getValue().equals(CLONE_READ_ONLY)) { |
There was a problem hiding this comment.
Thinking about this a little more, currently an invocation is not a compile-time-known value right?
So I think we should differentiate between the .cloneReadOnly we add, and what the user may have added for a field.
Shall we allow this only when this is the attachment itself, and return false for recursive checks?
MaryamZi
added
the
Team/CompilerFE
13 tasks
Annotation expr is wrapped in cloneReadOnly by internal desugar. We unwrap only this call and prevent other calls being unwrapped.
|
Closing as will be introduced changes by original PR:#23473 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Fixes #15533
#23473 (comment)
Check List