Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix MetricsTestCase broken by jballerina migration #21493

Merged
merged 1 commit into from
Mar 5, 2020
Merged

Fix MetricsTestCase broken by jballerina migration #21493

merged 1 commit into from
Mar 5, 2020

Conversation

riyafa
Copy link
Contributor

@riyafa riyafa commented Mar 5, 2020

Purpose

The MetricsTestCase failed because of incorrect migration.

Approach

fix JvmObservabilityGen.cleanUpServiceName method

Samples

N/A

Remarks

N/A

Check List

  • Read the Contributing Guide
  • Updated Change Log
  • Checked Tooling Support (#)
  • Added necessary tests
    • Unit Tests
    • Spec Conformance Tests
    • Integration Tests
    • Ballerina By Example Tests
  • Increased Test Coverage
  • Added necessary documentation
    • API documentation
    • Module documentation in Module.md files
    • Ballerina By Examples

@riyafa
Fix MetricsTestCase broken by jballerina migration
ae86e8c 
The MetricsTestCase failed because of incorrect migration.
@riyafa riyafa requested a review from Kishanthan March 5, 2020 09:19
@riyafa riyafa added the Team/jBallerina All the issues related to BIR, JVM backend code generation and runtime label Mar 5, 2020
@riyafa riyafa merged commit e4643c3 into ballerina-platform:master Mar 5, 2020
@riyafa riyafa deleted the fix-test branch March 5, 2020 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kishanthan Kishanthan Kishanthan approved these changes

Assignees

@riyafa riyafa

Labels
Team/jBallerina All the issues related to BIR, JVM backend code generation and runtime
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@riyafa @Kishanthan