Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Create local variable code action breaks code #20817

Merged
merged 1 commit into from
Feb 3, 2020
Merged

Fix Create local variable code action breaks code #20817

merged 1 commit into from
Feb 3, 2020

Conversation

rasika
Copy link
Contributor

@rasika rasika commented Jan 31, 2020 •
edited
Loading

Purpose

Fix Create local variable code action breaks code

Fixes #19627

Related PRs

#20818

Check List

  • Read the Contributing Guide
  • Updated Change Log
  • Checked Tooling Support (#)
  • Added necessary tests
    • Unit Tests
    • Spec Conformance Tests
    • Integration Tests
    • Ballerina By Example Tests
  • Increased Test Coverage
  • Added necessary documentation
    • API documentation
    • Module documentation in Module.md files
    • Ballerina By Examples

@rasika rasika added Team/CompilerFETools Semantic API, Formatter, Shell Team/LanguageServer Language Server Implementation related issues. #Compiler Type/Bug labels Jan 31, 2020
@rasika rasika added this to the Ballerina 1.2.0 milestone Jan 31, 2020
@rasika rasika mentioned this pull request Jan 31, 2020
Merged
13 tasks
@codecov-io
Copy link

Codecov Report

Merging #20817 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #20817   +/-   ##
=======================================
  Coverage   14.59%   14.59%           
=======================================
  Files          51       51           
  Lines        1398     1398           
  Branches      214      214           
=======================================
  Hits          204      204           
  Misses       1178     1178           
  Partials       16       16

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cd72529...af06634. Read the comment docs.

nadeeshaan
nadeeshaan approved these changes Feb 3, 2020
View reviewed changes
Copy link
Contributor

@nadeeshaan nadeeshaan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed

nadeeshaan
nadeeshaan approved these changes Feb 3, 2020
View reviewed changes
Copy link
Contributor

@nadeeshaan nadeeshaan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed

@rasika rasika merged commit 898ae60 into ballerina-platform:master Feb 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nadeeshaan nadeeshaan nadeeshaan approved these changes

Assignees
No one assigned
Labels
Team/CompilerFETools Semantic API, Formatter, Shell Team/LanguageServer Language Server Implementation related issues. #Compiler Type/Bug
Projects
None yet
Milestone
Ballerina 1.2.0
Development

Successfully merging this pull request may close these issues.

Create local variable code action breaks code
3 participants
@rasika @codecov-io @nadeeshaan