Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing pos and WS to identifier node #19532

Merged

Conversation

rdhananjaya
Copy link
Member

Purpose

$subject

Fixes #19472 (Need to verify with tooling team)

Approach

Describe how you are implementing the solutions along with the design details.

Samples

Provide high-level details about the samples related to this feature.

Remarks

List any other known issues, related PRs, TODO items, or any other notes related to the PR.

Check List

  • Read the Contributing Guide
  • Required Balo version update
  • Updated Change Log
  • Checked Tooling Support (#)
  • Added necessary tests
    • Unit Tests
    • Spec Conformance Tests
    • Integration Tests
    • Ballerina By Example Tests
  • Increased Test Coverage
  • Added necessary documentation
    • API documentation
    • Module documentation in Module.md files
    • Ballerina By Examples

@codecov-io
Copy link

Codecov Report

Merging #19532 into ballerina-1.0.x will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff                @@
##           ballerina-1.0.x   #19532   +/-   ##
================================================
  Coverage            15.73%   15.73%           
================================================
  Files                   47       47           
  Lines                 1265     1265           
  Branches               197      197           
================================================
  Hits                   199      199           
  Misses                1053     1053           
  Partials                13       13

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c059112...dc9d290. Read the comment docs.

@rdhananjaya rdhananjaya changed the base branch from ballerina-1.0.x to master October 31, 2019 05:11
@rdhananjaya rdhananjaya added Type/Improvement Team/CompilerFE All issues related to Language implementation and Compiler, this exclude run times. labels Oct 31, 2019
@rdhananjaya rdhananjaya added this to the Ballerina 1.1.0 milestone Oct 31, 2019
@nadeeshaan nadeeshaan merged commit b167099 into ballerina-platform:master Nov 5, 2019
@rdhananjaya rdhananjaya deleted the improve-identifier-pos branch August 24, 2020 02:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Team/CompilerFE All issues related to Language implementation and Compiler, this exclude run times. Type/Improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve identifier model
4 participants