Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Language Server] Fix goto definition for single bal files #15625

Merged

Conversation

NipunaRanasinghe
Copy link
Contributor

@NipunaRanasinghe NipunaRanasinghe commented Jun 10, 2019

Purpose

Fixes #15624.

Check List

  • Read the Contributing Guide
  • Required Balo version update
  • Updated Change Log
  • Checked Tooling Support (#)
  • Added necessary tests
    • Unit Tests
    • Spec Conformance Tests
    • Integration Tests
    • Ballerina By Example Tests
  • Increased Test Coverage
  • Added necessary documentation
    • API documentation
    • Module documentation in Module.md files
    • Ballerina By Examples

@codecov-io
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (master@d0de7f1). Click here to learn what that means.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master   #15625   +/-   ##
=========================================
  Coverage          ?    6.25%           
  Complexity        ?     1579           
=========================================
  Files             ?     1395           
  Lines             ?    71137           
  Branches          ?     9188           
=========================================
  Hits              ?     4452           
  Misses            ?    66200           
  Partials          ?      485
Impacted Files Coverage Δ Complexity Δ
...alang/langserver/BallerinaTextDocumentService.java 0% <0%> (ø) 0 <0> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d0de7f1...e0fbdf5. Read the comment docs.

Copy link
Contributor

@nadeeshaan nadeeshaan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@NipunaRanasinghe NipunaRanasinghe merged commit c5ed8b7 into ballerina-platform:master Jun 10, 2019
@NipunaRanasinghe NipunaRanasinghe deleted the ls-definition-fix branch June 10, 2019 11:19
@kaviththiranga kaviththiranga mentioned this pull request Jun 14, 2019
32 tasks
@NipunaRanasinghe NipunaRanasinghe restored the ls-definition-fix branch June 16, 2019 05:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Goto Definition does not work for project level bal files
3 participants