Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add data binding support for Artemis Connector #15334

Merged
merged 3 commits into from
Jun 3, 2019

Conversation

riyafa
Copy link
Contributor

@riyafa riyafa commented May 17, 2019

Purpose

Add data binding support for Artemis Connector

Approach

Dispatch messages to the resource based on resource signature

Samples

An example that shows data binding support with a record type.

Remarks

Improves fix for #15159

Check List

  • Read the Contributing Guide
  • Required Balo version update
  • Updated Change Log
  • Checked Tooling Support (#)
  • Added necessary tests
    • Unit Tests
    • Spec Conformance Tests
    • Integration Tests
    • Ballerina By Example Tests
  • Increased Test Coverage
  • Added necessary documentation
    • API documentation
    • Module documentation in Module.md files
    • Ballerina By Examples

@riyafa riyafa added Team/StandardLibs All Ballerina standard libraries Component/Messaging labels May 17, 2019
@riyafa riyafa force-pushed the jms branch 2 times, most recently from 5ca11aa to c29e177 Compare May 17, 2019 12:35
@codecov-io
Copy link

codecov-io commented May 17, 2019

Codecov Report

Merging #15334 into master will decrease coverage by 22.71%.
The diff coverage is 10.13%.

Impacted file tree graph

@@              Coverage Diff              @@
##             master   #15334       +/-   ##
=============================================
- Coverage     44.64%   21.93%   -22.72%     
- Complexity     4242     6479     +2237     
=============================================
  Files           602     1931     +1329     
  Lines         29228    88626    +59398     
  Branches       5026    12530     +7504     
=============================================
+ Hits          13050    19436     +6386     
- Misses        14556    66080    +51524     
- Partials       1622     3110     +1488
Impacted Files Coverage Δ Complexity Δ
...ng/artemis/externimpl/consumer/CreateConsumer.java 6.25% <ø> (ø) 2 <0> (?)
...saging/artemis/externimpl/message/GetProperty.java 11.11% <ø> (ø) 1 <0> (?)
...ng/messaging/artemis/externimpl/consumer/Stop.java 7.69% <ø> (ø) 1 <0> (?)
...saging/artemis/externimpl/message/GetBodySize.java 20% <ø> (ø) 1 <0> (?)
...saging/artemis/externimpl/message/PutProperty.java 5.55% <ø> (ø) 1 <0> (?)
...g/messaging/artemis/externimpl/consumer/Start.java 11.76% <ø> (ø) 1 <0> (?)
...essaging/artemis/externimpl/producer/IsClosed.java 16.66% <ø> (ø) 1 <0> (?)
.../externimpl/message/SaveToWritableByteChannel.java 7.69% <ø> (ø) 1 <0> (?)
.../messaging/artemis/externimpl/message/GetType.java 6.25% <ø> (ø) 1 <0> (?)
...ng/artemis/externimpl/producer/CreateProducer.java 8.33% <0%> (ø) 2 <0> (?)
... and 1341 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 50a02d8...533381c. Read the comment docs.

Copy link
Member

@MaryamZi MaryamZi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

index.json file needs to be updated for the new example?

@riyafa riyafa force-pushed the jms branch 7 times, most recently from caa65cd to a96a589 Compare May 29, 2019 09:53
riyafa added 3 commits June 3, 2019 09:46
The message object config for the received Message objects were not appropriately populated. This makes sure they are populated.
@riyafa riyafa merged commit 62b6e63 into ballerina-platform:master Jun 3, 2019
@riyafa riyafa deleted the jms branch June 3, 2019 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Team/StandardLibs All Ballerina standard libraries
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants