Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add partial text-document sync for LS #14121

Merged
merged 1 commit into from
Mar 12, 2019
Merged

Add partial text-document sync for LS #14121

merged 1 commit into from
Mar 12, 2019

Conversation

rasika
Copy link
Contributor

@rasika rasika commented Mar 5, 2019 •
edited
Loading

Purpose

Add incremental text-document sync for LS.

Moved Language Server Text Document sync from Full to Incremental. Incremental Document Sync can be found here. This minimized network bandwidth usage as only the diff is being sent.

@rasika rasika added Type/Improvement Team/LanguageServer Language Server Implementation related issues. #Compiler labels Mar 5, 2019
nadeeshaan
nadeeshaan approved these changes Mar 12, 2019
View reviewed changes
Copy link
Contributor

@nadeeshaan nadeeshaan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed

@nadeeshaan nadeeshaan changed the title [WIP] Add partial text-document sync for LS Add partial text-document sync for LS Mar 12, 2019
@nadeeshaan nadeeshaan merged commit cc1961f into ballerina-platform:master Mar 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nadeeshaan nadeeshaan nadeeshaan approved these changes

Assignees
No one assigned
Labels
Team/LanguageServer Language Server Implementation related issues. #Compiler Type/Improvement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rasika @nadeeshaan