Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typos in generated ClientConfig endpoint #11480

Merged
merged 3 commits into from
Nov 20, 2018

Conversation

ahochsteger
Copy link

Purpose

Fixes syntax errors in ballerina code that is generated using 'ballerina swagger client '

Approach

Replaced semikolons with commas.

@wggihan wggihan requested a review from hevayo November 19, 2018 07:29
@codecov-io
Copy link

Codecov Report

Merging #11480 into master will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master   #11480      +/-   ##
============================================
- Coverage     58.74%   58.74%   -0.01%     
  Complexity      393      393              
============================================
  Files          1963     1963              
  Lines         99258    99258              
  Branches      13608    13608              
============================================
- Hits          58312    58305       -7     
- Misses        35772    35773       +1     
- Partials       5174     5180       +6
Impacted Files Coverage Δ Complexity Δ
...rinalang/runtime/threadpool/ThreadPoolFactory.java 61.9% <0%> (-4.77%) 0% <0%> (ø)
...va/org/ballerinalang/channels/ChannelRegistry.java 94.59% <0%> (-2.71%) 0% <0%> (ø)
...lang/auth/ldap/nativeimpl/GetLdapScopesOfUser.java 54.54% <0%> (-2.03%) 0% <0%> (ø)
...va/org/ballerinalang/auth/ldap/util/LdapUtils.java 41.97% <0%> (-1.24%) 0% <0%> (ø)
...rg/ballerinalang/net/http/WebSocketDispatcher.java 88.7% <0%> (-1.08%) 0% <0%> (ø)
...a/org/ballerinalang/bre/bvm/GlobalMemoryBlock.java 79.2% <0%> (-1%) 0% <0%> (ø)
...et/http/actions/httpclient/AbstractHTTPAction.java 80.78% <0%> (-0.88%) 0% <0%> (ø)
.../java/org/ballerinalang/model/util/JsonParser.java 80.76% <0%> (-0.39%) 0% <0%> (ø)
...ain/java/org/ballerinalang/net/websub/hub/Hub.java 62.09% <0%> (+1.61%) 0% <0%> (ø) ⬇️
...inalang/bre/bvm/CallableWorkerResponseContext.java 75% <0%> (+3.75%) 0% <0%> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8df1779...ca2f961. Read the comment docs.

@rasika
Copy link
Contributor

rasika commented Nov 20, 2018

Thanks @ahochsteger !

@ahochsteger
Copy link
Author

Thanks for merging, @rasika :-).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants