Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

hostapp-update-hooks: fix updating grub on secured systems #3565

Closed
wants to merge 1 commit into from
Closed

hostapp-update-hooks: fix updating grub on secured systems #3565

wants to merge 1 commit into from

Conversation

jakogut
Copy link
Contributor

@jakogut jakogut commented Nov 27, 2024

Change-type: patch

Contributor checklist

Reviewer Guidelines

  • When submitting a review, please pick:
    • 'Approve' if this change would be acceptable in the codebase (even if there are minor or cosmetic tweaks that could be improved).
    • 'Request Changes' if this change would not be acceptable in our codebase (e.g. bugs, changes that will make development harder in future, security/performance issues, etc).
    • 'Comment' if you don't feel you have enough information to decide either way (e.g. if you have major questions, or you don't understand the context of the change sufficiently to fully review yourself, but want to make a comment)

@jakogut
hostapp-update-hooks: fix updating grub on secured systems
0926997 
Change-type: patch
Signed-off-by: Joseph Kogut <[email protected]>
@jakogut jakogut requested review from alexgg and mtoman November 27, 2024 02:09
@jakogut jakogut temporarily deployed to balena-staging.com November 27, 2024 02:10 — with GitHub Actions Inactive
@jakogut jakogut temporarily deployed to balena-staging.com November 27, 2024 02:10 — with GitHub Actions Inactive
@jakogut jakogut temporarily deployed to balena-staging.com November 27, 2024 02:10 — with GitHub Actions Inactive
@jakogut jakogut temporarily deployed to balena-staging.com November 27, 2024 02:10 — with GitHub Actions Inactive
@jakogut jakogut temporarily deployed to balena-staging.com November 27, 2024 02:10 — with GitHub Actions Inactive
@jakogut jakogut temporarily deployed to balena-staging.com November 27, 2024 02:10 — with GitHub Actions Inactive
@jakogut jakogut temporarily deployed to balena-staging.com November 27, 2024 02:10 — with GitHub Actions Inactive
@jakogut jakogut temporarily deployed to balena-staging.com November 27, 2024 02:10 — with GitHub Actions Inactive
@jakogut jakogut temporarily deployed to balena-staging.com November 27, 2024 02:10 — with GitHub Actions Inactive
@jakogut jakogut temporarily deployed to balena-staging.com November 27, 2024 02:10 — with GitHub Actions Inactive
@jakogut jakogut temporarily deployed to balena-staging.com November 27, 2024 02:10 — with GitHub Actions Inactive
@jakogut jakogut temporarily deployed to balena-staging.com November 27, 2024 02:10 — with GitHub Actions Inactive
@jakogut jakogut temporarily deployed to balena-staging.com November 27, 2024 02:10 — with GitHub Actions Inactive
@jakogut jakogut temporarily deployed to balena-staging.com November 27, 2024 02:10 — with GitHub Actions Inactive
@jakogut jakogut temporarily deployed to balena-staging.com November 27, 2024 02:10 — with GitHub Actions Inactive
@jakogut jakogut temporarily deployed to balena-staging.com November 27, 2024 02:10 — with GitHub Actions Inactive
@jakogut jakogut temporarily deployed to balena-staging.com November 27, 2024 02:10 — with GitHub Actions Inactive
@jakogut jakogut temporarily deployed to balena-staging.com November 27, 2024 02:10 — with GitHub Actions Inactive
@jakogut jakogut temporarily deployed to balena-staging.com November 27, 2024 02:10 — with GitHub Actions Inactive
@jakogut jakogut temporarily deployed to balena-staging.com November 27, 2024 02:10 — with GitHub Actions Inactive
@jakogut jakogut temporarily deployed to balena-staging.com November 27, 2024 02:10 — with GitHub Actions Inactive
@jakogut jakogut temporarily deployed to balena-staging.com November 27, 2024 02:10 — with GitHub Actions Inactive
@jakogut jakogut temporarily deployed to balena-staging.com November 27, 2024 02:10 — with GitHub Actions Inactive
@jakogut jakogut temporarily deployed to balena-staging.com November 27, 2024 02:10 — with GitHub Actions Inactive
@jakogut jakogut temporarily deployed to balena-staging.com November 27, 2024 02:10 — with GitHub Actions Inactive
@jakogut jakogut temporarily deployed to balena-staging.com November 27, 2024 02:10 — with GitHub Actions Inactive
@jakogut jakogut temporarily deployed to balena-staging.com November 27, 2024 02:10 — with GitHub Actions Inactive
@jakogut jakogut temporarily deployed to balena-staging.com November 27, 2024 02:10 — with GitHub Actions Inactive
@jakogut jakogut temporarily deployed to balena-staging.com November 27, 2024 02:10 — with GitHub Actions Inactive
@jakogut jakogut temporarily deployed to balena-staging.com November 27, 2024 02:10 — with GitHub Actions Inactive
@jakogut jakogut temporarily deployed to balena-staging.com November 27, 2024 02:10 — with GitHub Actions Inactive
@jakogut jakogut temporarily deployed to balena-staging.com November 27, 2024 02:10 — with GitHub Actions Inactive
@flowzone-app flowzone-app
Copy link
Contributor

flowzone-app bot commented Nov 27, 2024

Website deployed to CF Pages, 👀 preview link https://a90c05af.balena-os.pages.dev

@flowzone-app flowzone-app bot enabled auto-merge November 27, 2024 02:14
@jakogut jakogut temporarily deployed to balena-cloud.com November 27, 2024 02:55 — with GitHub Actions Inactive
@jakogut jakogut temporarily deployed to balena-cloud.com November 27, 2024 02:55 — with GitHub Actions Inactive
@jakogut jakogut temporarily deployed to balena-cloud.com November 27, 2024 02:55 — with GitHub Actions Inactive
@jakogut jakogut temporarily deployed to balena-cloud.com November 27, 2024 02:56 — with GitHub Actions Inactive
@jakogut jakogut temporarily deployed to balena-cloud.com November 27, 2024 02:56 — with GitHub Actions Inactive
@jakogut jakogut temporarily deployed to balena-cloud.com November 27, 2024 02:56 — with GitHub Actions Inactive
@jakogut jakogut temporarily deployed to balena-cloud.com November 27, 2024 02:59 — with GitHub Actions Inactive
@jakogut jakogut temporarily deployed to balena-cloud.com November 27, 2024 02:59 — with GitHub Actions Inactive
@jakogut jakogut temporarily deployed to balena-cloud.com November 27, 2024 02:59 — with GitHub Actions Inactive
alexgg
alexgg requested changes Nov 27, 2024
View reviewed changes
meta-balena-common/recipes-support/hostapp-update-hooks/files/99-resin-grub
@@ -91,7 +92,7 @@ grub_luks_cfg=$(find -L $BALENA_BOOT_MOUNTPOINT -name grub-luks.cfg)
grub_env=$(find -L $BALENA_BOOT_MOUNTPOINT -name grubenv)

if [ -n "$grub_luks_cfg" ]; then
if [ "$type" = "crypt" ]; then
if [ "$secureboot" = "true" ]; then
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nitpick: keep the format consistent ${secureboot}.

meta-balena-common/recipes-support/hostapp-update-hooks/files/99-resin-grub
@@ -75,7 +76,7 @@ else
fi

EFI_BINARY_SECUREBOOT="${EFI_BINARY}.secureboot"
if [ "${type}" = "crypt" ]; then
if [ "${secureboot}" = "true" ]; then
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nitpick: it's not really checking for secure boot though, is it? It's just checking whether the partitions are encrypted. I went for enc_part or similar in my PR.

@alexgg
Copy link
Contributor

alexgg commented Nov 27, 2024

@jakogut this is a subset of #3566. I am running a test using my branch and it contains one other fix.

@jakogut jakogut closed this Nov 27, 2024
auto-merge was automatically disabled November 27, 2024 16:46

Pull request was closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexgg alexgg alexgg requested changes

@mtoman mtoman Awaiting requested review from mtoman

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jakogut @alexgg