Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update-balena-supervisor: add network-online dependency #3492

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

rcooke-warwick
Copy link
Contributor

@rcooke-warwick rcooke-warwick commented Aug 14, 2024

There is a race condition present when purging a device and rebooting. If "update-balena-supervisor" comes up before the device can connect to the internet, it will fail to pull the supervisor image. As this service stops "balena-supervisor.service" , this isn't attempted again for at least 15 min = (up to 1 hour) when the "update-balena-supervisor.timer" triggers it.

Change-type: patch

Currently left in draft, in order to get a build to test with on a device


Contributor checklist

Reviewer Guidelines

  • When submitting a review, please pick:
    • 'Approve' if this change would be acceptable in the codebase (even if there are minor or cosmetic tweaks that could be improved).
    • 'Request Changes' if this change would not be acceptable in our codebase (e.g. bugs, changes that will make development harder in future, security/performance issues, etc).
    • 'Comment' if you don't feel you have enough information to decide either way (e.g. if you have major questions, or you don't understand the context of the change sufficiently to fully review yourself, but want to make a comment)

Copy link

github-actions bot commented Aug 14, 2024

Website deployed to CF Pages, 👀 preview link https://ba238015.balena-os.pages.dev

There is a race condition present when purging a device and rebooting. If "update-balena-supervisor" comes up before the device can connect to the internet, it will fail to pull the supervisor image. As this service stops "balena-supervisor.service" , this isn't attempted again for at least 15 min = (up to 1 hour) when the "update-balena-supervisor.timer" triggers it.

Change-type: patch
Signed-off-by: Ryan Cooke <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant