-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
patch: update documentation #4214
Open
aethernet
wants to merge
1
commit into
master
Choose a base branch
from
docs
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -17,41 +17,22 @@ Developing | |
|
||
#### Common | ||
|
||
- [NodeJS](https://nodejs.org) (at least v16.11) | ||
- [Python 3](https://www.python.org) | ||
- [jq](https://stedolan.github.io/jq/) | ||
- [curl](https://curl.haxx.se/) | ||
- [npm](https://www.npmjs.com/) | ||
|
||
```sh | ||
pip install -r requirements.txt | ||
``` | ||
|
||
You might need to run this with `sudo` or administrator permissions. | ||
- [NodeJS](https://nodejs.org) (check the required `enginge` version in `package.json`) | ||
- [Node-gyp](https://github.com/nodejs/node-gyp?tab=readme-ov-file#installation) toolchain (see their docs for your system requirements) | ||
|
||
#### Windows | ||
|
||
- [NSIS v2.51](http://nsis.sourceforge.net/Main_Page) (v3.x won't work) | ||
- Either one of the following: | ||
- [Visual C++ 2019 Build Tools](https://visualstudio.microsoft.com/vs/features/cplusplus/) containing standalone compilers, libraries and scripts | ||
- The [windows-build-tools](https://github.com/felixrieseberg/windows-build-tools#windows-build-tools) should be installed along with NodeJS | ||
- [Visual Studio Community 2019](https://visualstudio.microsoft.com/vs/) (free) (other editions, like Professional and Enterprise, should work too) | ||
**NOTE:** Visual Studio doesn't install C++ by default. You have to rerun the | ||
setup, select "Modify" and then check `Visual C++ -> Common Tools for Visual | ||
C++` (see http://stackoverflow.com/a/31955339) | ||
- [MinGW](http://www.mingw.org) | ||
|
||
You might need to `npm config set msvs_version 2019` for node-gyp to correctly detect | ||
the version of Visual Studio you're using (in this example VS2019). | ||
|
||
The following MinGW packages are required: | ||
|
||
- `msys-make` | ||
- `msys-unzip` | ||
- `msys-zip` | ||
- `msys-bash` | ||
- `msys-coreutils` | ||
|
||
#### macOS | ||
|
||
- [Xcode](https://developer.apple.com/xcode/) | ||
|
@@ -63,6 +44,8 @@ as well. | |
|
||
- `libudev-dev` for libusb (for example install with `sudo apt install libudev-dev`, or on fedora `systemd-devel` contains the required package) | ||
|
||
- Check the `hostDepencies` in `package.json` for the requirements for `debian`, you might need to adapt the package list for other distribution. | ||
|
||
### Cloning the project | ||
|
||
```sh | ||
|
@@ -84,17 +67,18 @@ Testing | |
|
||
To run the test suite, run the following command: | ||
|
||
For the unit tests | ||
```sh | ||
npm test | ||
npm wdio --suite gui --suite shared | ||
``` | ||
|
||
Given the nature of this application, not everything can be unit tested. For | ||
example: | ||
For the e2e tests you need: | ||
- to provide a test device (`TARGET_DRIVE`), this can be a virtual drive (check the `.github/actions/test/action.yml` for example on how to create the virtual drives for differnet OS). If you use a virtual drive on Mac, you'll need to set `ETCHER_INCLUDE_VIRTUAL_DRIVES` in the ENV. | ||
- to run with administator privileges (as the request cannot be automated). Use `sudo` (or `runas` on windows) | ||
|
||
- The writing operating on real raw devices. | ||
- Platform inconsistencies. | ||
- Style changes. | ||
- Artwork. | ||
```sh | ||
sudo npm wdio --suite e2e | ||
``` | ||
|
||
We encourage our contributors to test the application on as many operating | ||
systems as they can before sending a pull request. | ||
|
@@ -111,6 +95,7 @@ Updating a dependency | |
--------------------- | ||
|
||
- Install new version of dependency using npm | ||
- Run all tests (including e2e) | ||
- Commit *both* `package.json` and `npm-shrinkwrap.json`. | ||
|
||
Diffing Binaries | ||
|
@@ -146,6 +131,12 @@ Sending a pull request | |
|
||
When sending a pull request, consider the following guidelines: | ||
|
||
- Double check that your commits follows the [COMMIT-GUIDELINES.md][COMMIT-GUIDELINES] | ||
|
||
- Run the linter & prettifier with `npm run prettify` | ||
|
||
- Check that you're accidentally pushing some unrelated changes (i.e. formating, etc.) | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. "not accidentally" ? 😆 |
||
|
||
- Write a concise commit message explaining your changes. | ||
|
||
- If applies, write more descriptive information in the commit body. | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"hostDepencies" looks like a typo?