Fix auto updater #2875
Merged
Fix auto updater #2875
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thundron
force-pushed
the
fix-auto-updater
branch
2 times, most recently
from
5703a29 to
155fb8f
Compare
lurch
reviewed
Aug 5, 2019
thundron
force-pushed
the
fix-auto-updater
branch
2 times, most recently
from
82746b1 to
e549efb
Compare
zvin
suggested changes
Aug 6, 2019
|
Is the info at https://github.com/balena-io/etcher/blob/master/docs/USER-DOCUMENTATION.md#simulate-an-update-alert now out of date? |
thundron
force-pushed
the
fix-auto-updater
branch
2 times, most recently
from
a84fa5d to
a1c2b7b
Compare
zvin
suggested changes
Aug 6, 2019
thundron
force-pushed
the
fix-auto-updater
branch
from
a1c2b7b to
957942b
Compare
lurch
reviewed
Aug 6, 2019
zvin
suggested changes
Aug 6, 2019
lurch
reviewed
Aug 6, 2019
| try { | ||
| const release = await autoUpdater.checkForUpdates() | ||
| const isOutdated = semver.compare(release.updateInfo.version, version) > 0 | ||
| const shouldUpdate = parseInt(release.updateInfo.stagingPercentage, 10) > 0 |
There was a problem hiding this comment.
Are you sure this is necessary? Nothing I can find at https://www.electron.build/auto-update#staged-rollouts suggests you manually need to check the stagingPercentage value?
There was a problem hiding this comment.
@lurch It's because we manually check and then download, so it's an extra safety step before triggering the download for those connected with a data plan. One thing I didn't check is if release.updateInfo.version is unchanged in case no release is available (i.e. a newer release's stagingPercentage is 0), but I will
Change-type: patch Changelog-entry: Fix auto-updater check for updates Signed-off-by: Lorenzo Alberto Maria Ambrosi <[email protected]>
thundron
force-pushed
the
fix-auto-updater
branch
from
957942b to
8c2c4e2
Compare
zvin
approved these changes
Aug 19, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.