Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update angular-ui-router in npm-shrinkwrap.json #1102

Merged
merged 1 commit into from
Feb 16, 2017

Conversation

jviotti
Copy link
Contributor

@jviotti jviotti commented Feb 14, 2017

Looks like this dependency was not updated correctly on the shrinkwrap
file. Probably happened in the linked pull request, where the shrinkwrap
file was hand edited at some point (see PR discussion).

See: #1083
Signed-off-by: Juan Cruz Viotti [email protected]

Looks like this dependency was not updated correctly on the shrinkwrap
file. Probably happened in the linked pull request, where the shrinkwrap
file was hand edited at some point (see PR discussion).

See: #1083
Signed-off-by: Juan Cruz Viotti <[email protected]>
@jviotti jviotti merged commit 9e80f15 into master Feb 16, 2017
@jviotti jviotti deleted the update-shrinkwrap branch February 16, 2017 17:51
@lurch
Copy link
Contributor

lurch commented Feb 17, 2017

Huh? #1083 seemed to upgrade angular-ui-router to 0.4.2, but this PR seems to downgrade it back to 0.3.2 ??
(I don't quite understand how the shrinkwrap stuff works, so I may well be misunderstanding this, in which case an explanation would be great :) )

@jviotti
Copy link
Contributor Author

jviotti commented Feb 17, 2017

@lurch This refers to the angular-ui-router which is a dependency of angular-if-state, but not the top level one we use here (I know its a bit confusing :P), so it should be fine.

@lurch
Copy link
Contributor

lurch commented Feb 17, 2017

Ahhh, another case of NPM dependency hell ;-)
I'd missed the "dependency rather than top-level" part, thanks for clarifying.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants