test(GUI): fix non-running test in DrivesModel test suite #1061
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We have a test to ensure a drive is not auto-selected when its protected, however the real functionality of this test was not being tested given that the size the fake drive had was not enough to hold the image. Signed-off-by: Juan Cruz Viotti <[email protected]>
|
Related to this: presumably Etcher should also not auto-select system drives, when you've enabled 'dangerous mode'? Currently it does auto-select the system drive (when there's only one available), which IMHO doesn't "feel right"? |
|
Good point. I'll send a PR for it. |
jviotti
pushed a commit
that referenced
this pull request
Jan 31, 2017
Currently Etcher will auto-select a system drive if its the only available one when the "unsafe mode" is enabled, which doesn't feel right. Change-Type: patch Changelog-Entry: Don't auto select system drives in unsafe mode. See: #1061 Signed-off-by: Juan Cruz Viotti <[email protected]>
|
See #1069 |
jviotti
pushed a commit
that referenced
this pull request
Feb 6, 2017
Currently Etcher will auto-select a system drive if its the only available one when the "unsafe mode" is enabled, which doesn't feel right. Change-Type: patch Changelog-Entry: Don't auto select system drives in unsafe mode. See: #1061 Signed-off-by: Juan Cruz Viotti <[email protected]>
jviotti
pushed a commit
that referenced
this pull request
Feb 7, 2017
Currently Etcher will auto-select a system drive if its the only available one when the "unsafe mode" is enabled, which doesn't feel right. Change-Type: patch Changelog-Entry: Don't auto select system drives in unsafe mode. See: #1061 Signed-off-by: Juan Cruz Viotti <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have a test to ensure a drive is not auto-selected when its
protected, however the real functionality of this test was not being
tested given that the size the fake drive had was not enough to hold the
image.
Signed-off-by: Juan Cruz Viotti [email protected]