Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependency @balena/lint to v7 #267

Merged
merged 2 commits into from
Nov 24, 2023
Merged

Conversation

balena-renovate[bot]
Copy link
Contributor

@balena-renovate balena-renovate bot commented Sep 6, 2023

This PR contains the following updates:

Package Type Update Change
@balena/lint devDependencies major ^6.2.0 -> ^7.0.0

Release Notes

balena-io-modules/node-balena-lint (@​balena/lint)

v7.2.4

Compare Source

(2023-11-10)

  • Add missing .husky/pre-commit file [Pagan Gazzard]

v7.2.3

Compare Source

(2023-11-09)

  • Update yargs to 17.x [Pagan Gazzard]

v7.2.2

Compare Source

(2023-11-09)

  • Add no-constant-binary-expression to list of rules [Pagan Gazzard]

v7.2.1

Compare Source

(2023-10-18)

  • Update blob from 7.1.7 to 10.3.10 [Otávio Jacobi]

v7.2.0

Compare Source

(2023-09-12)

  • Add a deprecation notice for the --tests flag [Thodoris Greasidis]
  • Block .only in tests by default using eslint-plugin-no-only-tests [Thodoris Greasidis]

v7.1.2

Compare Source

(2023-09-11)

v7.1.1

Compare Source

(2023-08-29)

  • Allow using void as a way to silence floating promise errors [Thodoris Greasidis]

v7.1.0

Compare Source

(2023-08-29)

  • Error when detecting unused eslint disable directives [Thodoris Greasidis]

v7.0.2

Compare Source

(2023-08-23)

  • no-unused-vars: Allow _ prefixed unused vars in destructured arrays [Thodoris Greasidis]

v7.0.1

Compare Source

(2023-08-22)

  • Relax the prefer-const rule in destructuring expressions [Thodoris Greasidis]

v7.0.0

Compare Source

(2023-08-22)

  • .eslintrc.js: Update rules to make the migration easier [Thodoris Greasidis]
  • Update Prettier to v3 [Thodoris Greasidis]
  • Reduce custom rules in favor of typescript & eslint/recommended [Thodoris Greasidis]
  • Move to ESLint [Thodoris Greasidis]
  • Drop support for nodejs < 16.0.0 [Thodoris Greasidis]

Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Renovate Bot.

@balena-renovate balena-renovate bot force-pushed the renovate/balena-lint-7.x branch 3 times, most recently from 928c778 to bb76da7 Compare September 7, 2023 19:09
@balena-renovate
Copy link
Contributor Author

Edited/Blocked Notification

Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.

You can manually request rebase by checking the rebase/retry box above.

Warning: custom changes will be lost.

@balena-renovate balena-renovate bot force-pushed the renovate/balena-lint-7.x branch 2 times, most recently from b8207ce to 24c510b Compare November 1, 2023 20:59
@balena-renovate balena-renovate bot force-pushed the renovate/balena-lint-7.x branch 8 times, most recently from 8b574c6 to 1206721 Compare November 13, 2023 16:59
Update @balena/lint from 6.2.2 to 7.2.4

Change-type: patch
@balena-renovate balena-renovate bot force-pushed the renovate/balena-lint-7.x branch from 1206721 to 321a183 Compare November 13, 2023 17:57
@klutchell klutchell requested a review from thgreasi November 14, 2023 14:44
@thgreasi
Copy link
Member

@klutchell you will need to:

  • add a comment on all @ts-expect-errors (if you can't figure it out you can write "to make TS happy")
  • remove the tslint.json
  • optional: remove the --typescript flag from the balena-lint commands in the package.json

@klutchell klutchell requested a review from Page- November 24, 2023 16:11
src/balena-utils.ts Outdated Show resolved Hide resolved
@@ -1,34 +1,35 @@
import * as core from "@actions/core";
import { context as contextType } from "@actions/github";
import * as core from '@actions/core';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How was this passing linting before? Is the linting not run as part of CI?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was wondering the same thing. It looks like npm run lint is part of the tests but that wouldn't fix formatting.

Signed-off-by: Kyle Harding <[email protected]>
@klutchell klutchell force-pushed the renovate/balena-lint-7.x branch from 180e221 to a17f6a6 Compare November 24, 2023 18:10
@klutchell klutchell enabled auto-merge November 24, 2023 18:43
@klutchell
Copy link
Collaborator

I self-certify!

@klutchell klutchell merged commit 58eecda into master Nov 24, 2023
50 checks passed
@klutchell klutchell deleted the renovate/balena-lint-7.x branch November 24, 2023 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants