Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add multi_dockerignore option #249

Merged

Conversation

karaxuna
Copy link
Contributor

Change-type: minor

@karaxuna
Copy link
Contributor Author

@thgreasi can I get a review?

@ab77 ab77 force-pushed the karaxuna/add-multi-docker-ignore-option branch from c81aab6 to 45688c0 Compare March 23, 2023 17:39
@thgreasi thgreasi force-pushed the karaxuna/add-multi-docker-ignore-option branch from 45688c0 to f11ac92 Compare March 23, 2023 22:23
@@ -55,6 +55,10 @@ inputs:
description: Branch for finalizing releases
required: false
default: ""
multi_dockerignore:
description: Use service's dockerignore file
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@karaxuna after enabling external contributors, I now see a different error in CI
See: https://github.com/balena-io/deploy-to-balena-action/actions/runs/4505762867/jobs/7932156158#step:4:95

Can you try removing this ' and see whether that fixes the yml?

@klutchell
Copy link
Collaborator

The issue here is that this secondary job

test-deploy-to-cloud:
name: Test deploy to balenaCloud
runs-on: ubuntu-latest
needs: flowzone
if: github.event.action != 'closed'
steps:
- uses: actions/checkout@v3
- name: Replace the build image and Dockerfile for testing
run: |
# Use the Docker image built from the PR
yq e -i '.runs.image = "docker://ghcr.io/balena-io/deploy-to-balena-action:${{ github.event.pull_request.head.sha }}"' \
action.yml
# Overwrite the Dockerfile with minimal number of steps so the test deploy finishes quickly
echo FROM busybox > Dockerfile
- name: Deploy to a test fleet
uses: ./
with:
balena_token: ${{ secrets.BALENA_API_KEY }}
fleet: balena/deploy_to_balena_action
cache: false

Was not designed with pull_request_target (external contributions) in mind. We should change that job to a Flowzone custom test composite action and perform the same steps, but without the checkout.

@thgreasi thgreasi force-pushed the karaxuna/add-multi-docker-ignore-option branch from f11ac92 to db2cede Compare March 24, 2023 21:43
@thgreasi thgreasi merged commit b310773 into balena-io:master Mar 27, 2023
@thgreasi
Copy link
Member

Thanks for the PR @karaxuna and sorry for the delay on reviewing (and extending flowzone to allow external contributor PRs).

@karaxuna karaxuna deleted the karaxuna/add-multi-docker-ignore-option branch March 27, 2023 10:21
treygilliland added a commit to treygilliland/deploy-to-balena-action that referenced this pull request Oct 31, 2023
This change adds an option to use the --debug flag to the Balena push command to allow to see debug build logs.

This PR has been modeled after a similar PR to add the --multi-dockerignore flag [here](balena-io#249)
treygilliland added a commit to treygilliland/deploy-to-balena-action that referenced this pull request Oct 31, 2023
Change-type: minor

This change adds an option to use the --debug flag to the Balena push command to allow to see debug build logs.

This PR has been modeled after a similar PR to add the --multi-dockerignore flag [here](balena-io#249)
treygilliland added a commit to treygilliland/deploy-to-balena-action that referenced this pull request Oct 31, 2023
Change-type: minor

This change adds an option to use the --note flag to the Balena push command to add a note to the release

This PR has been modeled after a similar PR to add the --multi-dockerignore flag [here](balena-io#249)
treygilliland added a commit to treygilliland/deploy-to-balena-action that referenced this pull request Oct 31, 2023
This change adds an option to use the --note flag to the Balena push command to add a note to the release

This PR has been modeled after a similar PR to add the --multi-dockerignore flag [here](balena-io#249)

Change-type: minor
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants