Double quote PATH declaration in win32.bat #133
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Failing to do so can introduce problems when some of the directories in include spaces in their paths, eventually manifesting themselves as weird "is not recognized as an internal or external command, operable program or batch file" errors. See: balena-io/etcher#1025 Signed-off-by: Juan Cruz Viotti <[email protected]>
jviotti
pushed a commit
to balena-io/etcher
that referenced
this pull request
Jan 27, 2017
Change-Type: patch Changelog-Entry: Fix 'MySQL' is not recognised as an internal or external command error on Windows. See: balena-io-modules/drivelist#133 Fixes: #1025 Signed-off-by: Juan Cruz Viotti <[email protected]>
|
It's not the spaces in the path that's the problem, but having an |
jviotti
pushed a commit
to balena-io/etcher
that referenced
this pull request
Jan 30, 2017
Change-Type: patch Changelog-Entry: Fix 'MySQL' is not recognised as an internal or external command error on Windows. See: balena-io-modules/drivelist#133 Fixes: #1025 Signed-off-by: Juan Cruz Viotti <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Failing to do so can introduce problems when some of the directories in
include spaces in their paths, eventually manifesting themselves as
weird "is not recognized as an internal or external command,
operable program or batch file" errors.
See: balena-io/etcher#1025
Signed-off-by: Juan Cruz Viotti [email protected]