-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[feat] Implement custom inspect on sails.helpers #7282
[feat] Implement custom inspect on sails.helpers #7282
Conversation
Thanks for submitting this pull request, @DominusKelvin! We'll look at it ASAP. In the mean time, here are some ways you can help speed things along:
Please remember: never post in a public forum if you believe you've found a genuine security vulnerability. Instead, disclose it responsibly. For help with questions about Sails, click here. |
lib/hooks/helpers/index.js
Outdated
writable: true, | ||
value: function inspect(){ | ||
|
||
sails.helpers[Symbol.for('nodejs.util.inspect.custom')] = function customInspect() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Want to keep it non-enumerable so that code looping over the helpers doesn't break and think there's a helper called whatever this new symbol
requested changes have been addressed
This PR fixes issue #7281