-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[patch] fix node 14 warnings by upgrading prompt dependency #7084
[patch] fix node 14 warnings by upgrading prompt dependency #7084
Conversation
Hi @DominusKelvin! It looks like the title of your pull request doesn’t quite match our guidelines yet. Would you please edit your pull request's title so that it begins with |
Thanks for submitting this pull request, @DominusKelvin! We'll look at it ASAP. In the mean time, here are some ways you can help speed things along:
Please remember: never post in a public forum if you believe you've found a genuine security vulnerability. Instead, disclose it responsibly. For help with questions about Sails, click here. |
Hi @DominusKelvin, Would you be able to describe the bug this is fixing in more detail? I want to make sure I'm looking for the right thing when I test this out. Thanks for the PR! |
@eashaw if you run sails lift on Node.js 14 and above you get a warning about circular dependency. This patch fixes that. |
@eashaw here is a Loom video showing the reason why for this Patch |
@eashaw any word on this yet? |
package.json
Outdated
@@ -54,7 +54,7 @@ | |||
"parseurl": "1.3.2", | |||
"path-to-regexp": "1.5.3", | |||
"pluralize": "1.2.1", | |||
"prompt": "0.2.14", | |||
"prompt": "^1.1.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since prompt
is an externally maintained dep, lets use a strict semver range 1.1.0
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay that works well
same idea as balderdashy/sails-hook-orm@f194253
No description provided.