Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that
req.view
determines what to render based on what's inreq.options
, I don't see the utility of having a middleware function bound for each individual view, hence the removal of most of the code inlib/hooks/views/action.js
. If I'm missing something, lemme know. Tests all pass without it though.Also added new tests for using the view target syntax (e.g.
'/foo': {view: 'foo/bar/baz'}
) and a test for the ability to do'/foo': {view: 'foo'}
and have it renderviews/foo/index.js
if it exists--not sure if that was ever documented, but the code was is in there so I made sure it still works.