-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added LiveScript support #2662
Added LiveScript support #2662
Conversation
322f39a
to
a4b6479
Compare
I am ok with that. What do you think @tjwebb ? |
Looks good to me, thanks @loicsaintroch |
OK...I'm annoyed now.. I put together a pull request #2599 that added support for:
It's been rotting in the queue for months and somehow this got merged?!?! I'm not saying this is bad code, but I feel like someone cut the line! If my PR is bad tell me what to fix, but I feel a little cheated here. @borestad please dont be offended, nothing against you. But I think your job may have been easier had they merged mine first... |
@internalfx hey man, sorry about that. We've been going through Pull Requests and trying to catch up with merging in useful things. But I think we've been going in the wrong order. I see your point. I'd be annoyed too. If you don't mind merging latest into your PR so we can merge without conflicts, I'll make a point to review your PR next and merge it. Thanks. |
@tjwebb Happy to do it....and thanks I'm reworking my PR to also include LiveScript support..so everyone wins! |
Thanks, and I apologize again for our oversight. We're in the process of re-organizing the core team so that we can start moving forward at a more rapid pace, and so we can be more responsive to these kinds of issues. Are you interested in being involved in this process? |
Hi.
I added support for LiveScript. Even though #2122 seems like a better solution in the long run, it solves my needs. I didn't add support for scaffolding.
Is this something that you may find interesting to merge?