-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Latest version of connect-mongo not supported by session hook #7168
Closed
ElizabethForest opened this issue
Aug 18, 2021
· 1 comment
· Fixed by #7172 · May be fixed by FalconSocial/frontend-assignment#22
Closed
Latest version of connect-mongo not supported by session hook #7168
ElizabethForest opened this issue
Aug 18, 2021
· 1 comment
· Fixed by #7172 · May be fixed by FalconSocial/frontend-assignment#22
Comments
@ElizabethForest Thanks for posting! We'll take a look as soon as possible. In the mean time, there are a few ways you can help speed things along:
Please remember: never post in a public forum if you believe you've found a genuine security vulnerability. Instead, disclose it responsibly. For help with questions about Sails, click here. |
eashaw
added a commit
that referenced
this issue
Sep 16, 2021
[fixes #7168] Add support for latest version of connect-mongo
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Node version: v10.6.0
Sails version (sails): v1.4.4
ORM hook version (sails-hook-orm): v3.0.2
Sockets hook version (sails-hook-sockets): v2.0.1
Organics hook version (sails-hook-organics): -
Grunt hook version (sails-hook-grunt): v4.0.1
Uploads hook version (sails-hook-uploads): -
DB adapter & version (e.g. [email protected]): -
Skipper adapter & version (e.g. [email protected]): -
connect-mongo version: v4.5.0
The latest version of
connect-mongo
(v4) is not supported by the Sails session hook. This is a problem for me because it implements an important bug fix.The
connect-mongo
update is a breaking change with the key difference (mentioned in theconnect-mongo
migration docs):This causes an error at https://github.com/balderdashy/sails/blob/master/lib/hooks/session/index.js#L405
I am happy to look at implementing a fix and submitting a PR. I assume the fix would need to be backwards compatible with the older versions of
connect-mongo
?The text was updated successfully, but these errors were encountered: